Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): improve group title display for checkbox columns #9622

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

zzj3720
Copy link
Member

@zzj3720 zzj3720 commented Jan 9, 2025

close: BS-1977

@zzj3720 zzj3720 requested a review from a team as a code owner January 9, 2025 16:25
@graphite-app graphite-app bot requested a review from forehalo January 9, 2025 16:25
Copy link

graphite-app bot commented Jan 9, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.86%. Comparing base (8e8058a) to head (20ca4f3).

Files with missing lines Patch % Lines
.../affine/data-view/src/core/group-by/group-title.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9622      +/-   ##
==========================================
+ Coverage   52.84%   52.86%   +0.02%     
==========================================
  Files        2180     2180              
  Lines       98430    98434       +4     
  Branches    16693    16694       +1     
==========================================
+ Hits        52012    52040      +28     
+ Misses      45014    44952      -62     
- Partials     1404     1442      +38     
Flag Coverage Δ
server-test 77.83% <ø> (-0.04%) ⬇️
unittest 32.35% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant