fix(legacy): uint64 protobuf field decoding #4535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
andrewkozlik
approved these changes
Jan 24, 2025
andrewkozlik
approved these changes
Jan 24, 2025
[no changelog]
mmilata
force-pushed
the
mmilata/legacy-pb64
branch
from
28af56d to
522fd6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3892 hopefully.
It seems that some Cortex-M3 instructions support unaligned access and some don't? Couldn't find it explained in a single place, however it seems that STRD (64bit store) can't handle it.