Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version of Hydra to 1.11.9 (multiarch) #13634

Closed
wants to merge 1 commit into from

Conversation

mdesmet
Copy link
Contributor

@mdesmet mdesmet commented Aug 12, 2022

Description

Upgrade of Hydra container for usage in core tests. The upgraded image also supports ARM64, instead of only AMD64 in the older image. Which makes tests run more predictable and fast on M1 machines.

Release notes of Hydra v1.11.9

Is this change a fix, improvement, new feature, refactoring, or other?

Fix

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Tests in core engine

How would you describe this change to a non-technical end user or system administrator?

Related issues, pull requests, and links

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Aug 12, 2022
@@ -69,7 +69,7 @@
public class TestingHydraIdentityProvider
implements AutoCloseable
{
private static final String HYDRA_IMAGE = "oryd/hydra:v1.10.6";
private static final String HYDRA_IMAGE = "oryd/hydra:v1.11.9";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Do we have any release notes for the new version, which we could link as a part of the PR description.

@mdesmet
Copy link
Contributor Author

mdesmet commented Sep 6, 2022

@Praveen2112: Is this good to go?

@mosabua
Copy link
Member

mosabua commented Jan 12, 2024

@Praveen2112 @mdesmet @martint .. I think we should check if a newer suitable version is available ( I see 2.1.2 ) and merge .. might help test performance among other things.

Copy link

github-actions bot commented Sep 4, 2024

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Sep 4, 2024
@mosabua
Copy link
Member

mosabua commented Sep 10, 2024

This is outdated .. latest version is 2.2.0. Want to update @mdesmet and maybr ping @wendigo @Praveen2112 or myself?

@github-actions github-actions bot removed the stale label Sep 11, 2024
Copy link

github-actions bot commented Oct 3, 2024

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Oct 3, 2024
@mosabua
Copy link
Member

mosabua commented Oct 3, 2024

@Praveen2112 @wendigo .. any objections or concerns with merging this? At first glance the test failures look to be unrelated.

@wendigo
Copy link
Contributor

wendigo commented Oct 4, 2024

@mosabua Yeah, doesn't work. Tests failures are related

@github-actions github-actions bot removed the stale label Oct 4, 2024
@mosabua
Copy link
Member

mosabua commented Oct 4, 2024

Cool.. thanks @wendigo .. @mdesmet I assume you will investigate and expand this PR as needed.

@mosabua mosabua added the stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed. label Oct 21, 2024
@mosabua
Copy link
Member

mosabua commented Oct 21, 2024

Confirmed with @mdesmet that he will continue work on this.

@mosabua
Copy link
Member

mosabua commented Jan 20, 2025

Master is already at 1.11.10 .. and 2.x doesnt work. For now I think we should just close this PR and start a new one whenever @mdesmet or somebody else wants to work on it.

@mosabua mosabua closed this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed.
Development

Successfully merging this pull request may close these issues.

5 participants