-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version of Hydra to 1.11.9 (multiarch) #13634
Conversation
@@ -69,7 +69,7 @@ | |||
public class TestingHydraIdentityProvider | |||
implements AutoCloseable | |||
{ | |||
private static final String HYDRA_IMAGE = "oryd/hydra:v1.10.6"; | |||
private static final String HYDRA_IMAGE = "oryd/hydra:v1.11.9"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Do we have any release notes for the new version, which we could link as a part of the PR description.
@Praveen2112: Is this good to go? |
@Praveen2112 @mdesmet @martint .. I think we should check if a newer suitable version is available ( I see 2.1.2 ) and merge .. might help test performance among other things. |
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
This is outdated .. latest version is 2.2.0. Want to update @mdesmet and maybr ping @wendigo @Praveen2112 or myself? |
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
@Praveen2112 @wendigo .. any objections or concerns with merging this? At first glance the test failures look to be unrelated. |
@mosabua Yeah, doesn't work. Tests failures are related |
Confirmed with @mdesmet that he will continue work on this. |
Master is already at 1.11.10 .. and 2.x doesnt work. For now I think we should just close this PR and start a new one whenever @mdesmet or somebody else wants to work on it. |
Description
Upgrade of Hydra container for usage in core tests. The upgraded image also supports ARM64, instead of only AMD64 in the older image. Which makes tests run more predictable and fast on M1 machines.
Release notes of Hydra v1.11.9
Fix
Tests in core engine
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
( ) Release notes entries required with the following suggested text: