Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that TableScanNode's assignments match the output symbols #24764

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

kasiafi
Copy link
Member

@kasiafi kasiafi commented Jan 22, 2025

Before this change, only one-way match was verified: that each output symbol is backed by an assignment.

no docs or relnotes needed

@cla-bot cla-bot bot added the cla-signed label Jan 22, 2025
Copy link
Member

@Praveen2112 Praveen2112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix the test failures in TestMultipleDistinctAggregationsToSubqueries#testGroupByWithDistinctToSubqueries

Before this change, only one-way match was verified: that each
output symbol is backed by an assignment.
@kasiafi kasiafi force-pushed the 534TableScanVerify branch from 891dd2d to c27edb5 Compare January 22, 2025 16:31
@kasiafi kasiafi merged commit 417f8fe into trinodb:master Jan 22, 2025
94 checks passed
@github-actions github-actions bot added this to the 469 milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants