Move byte manipulation ops from elwise ops conversion. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilya Enkovich <[email protected]>
minjang
approved these changes
Jun 20, 2024
minjang
pushed a commit
to minjang/triton-cpu
that referenced
this pull request
Jun 22, 2024
Signed-off-by: Ilya Enkovich <[email protected]>
minjang
pushed a commit
that referenced
this pull request
Jun 24, 2024
Signed-off-by: Ilya Enkovich <[email protected]>
Devjiu
pushed a commit
to Devjiu/triton-cpu
that referenced
this pull request
Aug 13, 2024
Signed-off-by: Ilya Enkovich <[email protected]>
int3
pushed a commit
that referenced
this pull request
Aug 29, 2024
Signed-off-by: Ilya Enkovich <[email protected]>
minjang
pushed a commit
that referenced
this pull request
Sep 22, 2024
Signed-off-by: Ilya Enkovich <[email protected]>
minjang
pushed a commit
that referenced
this pull request
Oct 22, 2024
Signed-off-by: Ilya Enkovich <[email protected]>
minjang
pushed a commit
that referenced
this pull request
Oct 24, 2024
Signed-off-by: Ilya Enkovich <[email protected]>
int3
pushed a commit
that referenced
this pull request
Dec 6, 2024
Signed-off-by: Ilya Enkovich <[email protected]>
ienkovich
added a commit
that referenced
this pull request
Dec 6, 2024
Signed-off-by: Ilya Enkovich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have many operation conversions in
ConvertElementwiseOpspass and some of them are not actually elementeise. It started with a single pattern because it was not reasonable to introduce a new pass for it, but more and more operations were added later. This patch moves those patterns into a new pass that covers vector element manipulations, like shuffles, broadcasts, etc. This is pure refactoring, with no functional changes