-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(custom-domain): allow to use custom domain #9106
Closed
Closed
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
f807021
WIP
AMoreaux 7b746e6
Merge remote-tracking branch 'origin/main' into feat/allow-to-use-cus…
AMoreaux 329ff83
feat(domain-manager): centralize and extend subdomain handling
AMoreaux 3fa8df1
refactor(workspace, domain-manager): replace 'domain' with 'hostname'
AMoreaux 1256151
add migration
AMoreaux f184330
WIP
AMoreaux 8d3d5b4
feat(domain-manager): centralize and extend subdomain handling
AMoreaux 34ad83c
refactor(workspace, domain-manager): replace 'domain' with 'hostname'
AMoreaux f06effe
add migration
AMoreaux 36ea594
Merge remote-tracking branch 'origin/feat/allow-to-use-custom-domain'…
AMoreaux 24653e0
WIP
AMoreaux 6e66db1
WIP
AMoreaux f4b35df
Merge remote-tracking branch 'origin/main' into feat/allow-to-use-cus…
AMoreaux c62e0f8
WIP
AMoreaux c64136b
Merge remote-tracking branch 'origin/main' into feat/allow-to-use-cus…
AMoreaux 4fc89b3
[refactor](auth): Simplify invitation handling and SSO flow
AMoreaux e658f75
WIP
AMoreaux 78652c2
[refactor]: Remove switch workspace functionality
AMoreaux a4482a2
[refactor]: Simplify domain settings components
AMoreaux 21b8ce6
[refactor]: Simplify domain settings components
AMoreaux a94c9f7
Merge remote-tracking branch 'origin/main' into feat/allow-to-use-cus…
AMoreaux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,3 +40,4 @@ dump.rdb | |
/devenv.nix | ||
/flake.lock | ||
/flake.nix | ||
/qodana.yaml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -109,6 +109,7 @@ export type AuthorizeApp = { | |
export type AvailableWorkspaceOutput = { | ||
__typename?: 'AvailableWorkspaceOutput'; | ||
displayName?: Maybe<Scalars['String']['output']>; | ||
hostname?: Maybe<Scalars['String']['output']>; | ||
id: Scalars['String']['output']; | ||
logo?: Maybe<Scalars['String']['output']>; | ||
sso: Array<SsoConnection>; | ||
|
@@ -305,6 +306,14 @@ export type CursorPaging = { | |
last?: InputMaybe<Scalars['Int']['input']>; | ||
}; | ||
|
||
export type CustomHostnameDetails = { | ||
__typename?: 'CustomHostnameDetails'; | ||
hostname: Scalars['String']['output']; | ||
ownership_verification?: Maybe<OwnershipVerification>; | ||
ownership_verification_http?: Maybe<OwnershipVerificationHttp>; | ||
status: Scalars['String']['output']; | ||
}; | ||
|
||
export type DeleteOneFieldInput = { | ||
/** The id of the field to delete. */ | ||
id: Scalars['UUID']['input']; | ||
|
@@ -395,6 +404,7 @@ export enum FeatureFlagKey { | |
IsCommandMenuV2Enabled = 'IsCommandMenuV2Enabled', | ||
IsCopilotEnabled = 'IsCopilotEnabled', | ||
IsCrmMigrationEnabled = 'IsCrmMigrationEnabled', | ||
IsCustomDomainEnabled = 'IsCustomDomainEnabled', | ||
IsEventObjectEnabled = 'IsEventObjectEnabled', | ||
IsFreeAccessEnabled = 'IsFreeAccessEnabled', | ||
IsFunctionSettingsEnabled = 'IsFunctionSettingsEnabled', | ||
|
@@ -405,7 +415,6 @@ export enum FeatureFlagKey { | |
IsSsoEnabled = 'IsSSOEnabled', | ||
IsStripeIntegrationEnabled = 'IsStripeIntegrationEnabled', | ||
IsUniqueIndexesEnabled = 'IsUniqueIndexesEnabled', | ||
IsViewGroupsEnabled = 'IsViewGroupsEnabled', | ||
IsWorkflowEnabled = 'IsWorkflowEnabled' | ||
} | ||
|
||
|
@@ -511,7 +520,7 @@ export enum IdentityProviderType { | |
export type ImpersonateOutput = { | ||
__typename?: 'ImpersonateOutput'; | ||
loginToken: AuthToken; | ||
workspace: WorkspaceSubdomainAndId; | ||
workspace: WorkspaceSubdomainHostnameAndId; | ||
}; | ||
|
||
export type IndexConnection = { | ||
|
@@ -621,7 +630,6 @@ export type Mutation = { | |
sendInvitations: SendInvitationsOutput; | ||
signUp: SignUpOutput; | ||
skipSyncEmailOnboardingStep: OnboardingStepSuccess; | ||
switchWorkspace: PublicWorkspaceDataOutput; | ||
syncRemoteTable: RemoteTable; | ||
syncRemoteTableSchemaChanges: RemoteTable; | ||
track: Analytics; | ||
|
@@ -852,11 +860,6 @@ export type MutationSignUpArgs = { | |
}; | ||
|
||
|
||
export type MutationSwitchWorkspaceArgs = { | ||
workspaceId: Scalars['String']['input']; | ||
}; | ||
|
||
|
||
export type MutationSyncRemoteTableArgs = { | ||
input: RemoteTableInput; | ||
}; | ||
|
@@ -992,6 +995,19 @@ export type OnboardingStepSuccess = { | |
success: Scalars['Boolean']['output']; | ||
}; | ||
|
||
export type OwnershipVerification = { | ||
__typename?: 'OwnershipVerification'; | ||
name: Scalars['String']['output']; | ||
type: Scalars['String']['output']; | ||
value: Scalars['String']['output']; | ||
}; | ||
|
||
export type OwnershipVerificationHttp = { | ||
__typename?: 'OwnershipVerificationHttp'; | ||
http_body: Scalars['String']['output']; | ||
http_url: Scalars['String']['output']; | ||
}; | ||
|
||
export type PageInfo = { | ||
__typename?: 'PageInfo'; | ||
/** The cursor of the last returned record. */ | ||
|
@@ -1030,6 +1046,7 @@ export type PublicWorkspaceDataOutput = { | |
__typename?: 'PublicWorkspaceDataOutput'; | ||
authProviders: AuthProviders; | ||
displayName?: Maybe<Scalars['String']['output']>; | ||
hostname?: Maybe<Scalars['String']['output']>; | ||
id: Scalars['String']['output']; | ||
logo?: Maybe<Scalars['String']['output']>; | ||
subdomain: Scalars['String']['output']; | ||
|
@@ -1059,6 +1076,7 @@ export type Query = { | |
findWorkspaceFromInviteHash: Workspace; | ||
findWorkspaceInvitations: Array<WorkspaceInvitation>; | ||
getAvailablePackages: Scalars['JSON']['output']; | ||
getHostnameDetails?: Maybe<CustomHostnameDetails>; | ||
getPostgresCredentials?: Maybe<PostgresCredentials>; | ||
getProductPrices: ProductPricesEntity; | ||
getPublicWorkspaceDataBySubdomain: PublicWorkspaceDataOutput; | ||
|
@@ -1412,7 +1430,7 @@ export type SetupSsoOutput = { | |
export type SignUpOutput = { | ||
__typename?: 'SignUpOutput'; | ||
loginToken: AuthToken; | ||
workspace: WorkspaceSubdomainAndId; | ||
workspace: WorkspaceSubdomainHostnameAndId; | ||
}; | ||
|
||
/** Sort Directions */ | ||
|
@@ -1612,7 +1630,8 @@ export type UpdateWorkflowVersionStepInput = { | |
export type UpdateWorkspaceInput = { | ||
allowImpersonation?: InputMaybe<Scalars['Boolean']['input']>; | ||
displayName?: InputMaybe<Scalars['String']['input']>; | ||
domainName?: InputMaybe<Scalars['String']['input']>; | ||
domain?: InputMaybe<Scalars['String']['input']>; | ||
hostname?: InputMaybe<Scalars['String']['input']>; | ||
inviteHash?: InputMaybe<Scalars['String']['input']>; | ||
isGoogleAuthEnabled?: InputMaybe<Scalars['Boolean']['input']>; | ||
isMicrosoftAuthEnabled?: InputMaybe<Scalars['Boolean']['input']>; | ||
|
@@ -1741,9 +1760,9 @@ export type Workspace = { | |
databaseUrl: Scalars['String']['output']; | ||
deletedAt?: Maybe<Scalars['DateTime']['output']>; | ||
displayName?: Maybe<Scalars['String']['output']>; | ||
domainName?: Maybe<Scalars['String']['output']>; | ||
featureFlags?: Maybe<Array<FeatureFlag>>; | ||
hasValidEntrepriseKey: Scalars['Boolean']['output']; | ||
hostname?: Maybe<Scalars['String']['output']>; | ||
id: Scalars['UUID']['output']; | ||
inviteHash?: Maybe<Scalars['String']['output']>; | ||
isGoogleAuthEnabled: Scalars['Boolean']['output']; | ||
|
@@ -1852,8 +1871,9 @@ export type WorkspaceNameAndId = { | |
id: Scalars['String']['output']; | ||
}; | ||
|
||
export type WorkspaceSubdomainAndId = { | ||
__typename?: 'WorkspaceSubdomainAndId'; | ||
export type WorkspaceSubdomainHostnameAndId = { | ||
__typename?: 'WorkspaceSubdomainHostnameAndId'; | ||
hostname?: Maybe<Scalars['String']['output']>; | ||
id: Scalars['String']['output']; | ||
subdomain: Scalars['String']['output']; | ||
}; | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check failure
Code scanning / CodeQL
Disabling certificate validation High
Copilot Autofix AI 16 days ago
To fix the problem, we should ensure that certificate validation is not disabled. This can be done by removing the line that sets
process.env.NODE_TLS_REJECT_UNAUTHORIZED
to '0'. If this setting is necessary for development or testing purposes, it should be conditionally applied based on the environment.The best way to fix this without changing existing functionality is to check if the environment is development or testing before setting
process.env.NODE_TLS_REJECT_UNAUTHORIZED
. This way, we can ensure that certificate validation is only disabled in non-production environments.