-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR43 follow-up: replace the problematic nested volume mounts with bind mounts and add shared init volume container #55
base: master
Are you sure you want to change the base?
Conversation
… a shared volume init container. This is as proposed in relation to PR43 and the fallout it caused regarding build errors and races in launch from pristine clone e.g. when running in the existing CI. Introduces the shared volume pre-init container to eliminate start-up races. Uses env variables to allow flexible vgrid_files_readonly and mig_system_run locations, in order to hopefully address the needs originally motivating PR43.
@jonasbardino I have not tried to implement this into my system, but it get an error.
my volumes for migrid is the following in docker-compose.override.yml
|
Can you please verify that you don't end up with a
|
You can find good hints about suitable values for the three new bind source-related variables in |
When you introduce variables into docker-compose, then i cannot override them, so it does not make any sense to have docker-compose.override, but that leaves me with alot of problems with the other stuff already in my docker-compose.override. |
I'm not sure I understand why you'd want to have docker-compose overrides for values that you can already configure in env. Doesn't it give you the necessary flexibility to 'just' specify your custom locations there? |
This is my current docker-compose.override |
This is as proposed in relation to PR43 and the fallout it caused regarding build errors and races in launch from pristine clone e.g. when running in the existing CI.
Introduces the shared volume pre-init container to eliminate start-up races.
Uses env variables to allow flexible vgrid_files_readonly and mig_system_run locations, in order to hopefully address the needs originally motivating PR43.