Introduce structured arg parsing and reimpelement generateconfs atop it. #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
albu-diku
force-pushed
the
addition/argparse-generateconfs
branch
from
51df8e2 to
d8bf548
Compare
albu-diku
changed the title
albu-diku
force-pushed
the
refactor/split-out-install-defaults
branch
from
bab43cd to
ff29485
Compare
Prior work made the defaults used for command line arguments in the generateconfs utility accessible as a structure. Make use of this to jettison our custom code and instead use all the user-facing niceties of the argparse library. This commit introduces a argument parsing wrapper for local use named minimist in a nod to the node library of the same name from which we largely borrow the externally facing API. It was remarkably suitable for our purposes and a close match to our existing code which operates in terms of arrays of argument names which must be treated a certain way i.e. string, boolean, etc.
albu-diku
force-pushed
the
addition/argparse-generateconfs
branch
from
d8bf548 to
357a99c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior work made the defaults used for command line arguments in the
generateconfs utility accessible as a structure. Make use of this to
jettison our custom code and instead use all the user-facing niceties
of the argparse library.
This commit introduces a argument parsing wrapper for local use named
minimist in a nod to the node library of the same name from which we
largely borrow the externally facing API. It was remarkably suitable
for our purposes and a close match to our existing code which operates
in terms of arrays of argument names which must be treated a certain
way i.e. string, boolean, etc.
Depends on: #83