-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add the ability to create a PR with the incoming changelog #110
base: main
Are you sure you want to change the base?
Conversation
I think for first step, we can introduce a |
src/commands/default.ts
Outdated
// Push the branch to the origin | ||
await execa("git", ["push", "-u", "origin", "v" + config.newVersion], { cwd }); | ||
} | ||
// Maybe we can create a new command to do this? (we don't want to create a release an a pull request at the same time but I don't know if this must be managed from the config or from the CLI) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can support changelogen github pull-request|issue
(inside commands/github.ts
)
Ok, if I understand well, you can to have a command to add changelog to an issue and another one to add changelog to a PR which also update package version? |
@pi0 can you tell me if direction is correct before I continue to create code? Still wip but I want to be sure that I'm not doing something wrong! |
Hello @danielroe, could you please review this PR when you have a bit of time? Thanks a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Barbapapazes - so sorry for the very long delay on this one! I'm sorry.
If you're happy to take a bit more on this to rebase/merge it with current changelogen
, I'll review. Let me know any particular areas that you think need attention. 🙏
Hello,
This PR follows nuxt/nuxt#20675.
It's a first draft because I'm not sure on how we must handle the PR. In fact, have we to reuse code from the release, create a new condition or a new command?
Also, we need to:
Support for workspace will coming after #18 is finished.