-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add docs about raw method #271
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #271 +/- ##
===========================================
- Coverage 61.08% 28.11% -32.97%
===========================================
Files 13 41 +28
Lines 1380 2998 +1618
Branches 58 86 +28
===========================================
Hits 843 843
- Misses 537 2127 +1590
- Partials 0 28 +28 β View full report in Codecov by Sentry. |
Do you think you could add an example in |
Thanks for helping document this feature. BTW keep note that it is an advanced feature I introduced back then as an escape hatch. We probably should consider it. |
@pi0 to be honest, by writing the docs I wasn't feeling comfortable with the strange behavior of reporters when we are passing an object containing an args key.. |
I'm not fully confident by doing this documentation as raw method looks like a rescue patch to a potential issue of consola. I'm wondering why consola permits those conflicts by passing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
π Linked issue
Closes #268
β Type of change
π Description
Add a chapter about the raw function to bypass potential bad interpretation from reporter.
π Checklist