-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct gitlab repository path #141
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
===========================================
- Coverage 54.63% 43.82% -10.81%
===========================================
Files 7 6 -1
Lines 615 470 -145
Branches 47 47
===========================================
- Hits 336 206 -130
+ Misses 278 263 -15
Partials 1 1 β View full report in Codecov by Sentry. |
Hi. Sorry for delay on this. I mainly wanted to double check if both with and without subgroups it works and didn't had a chance to make a testing gitlab structure yet. If you have some it can be helpful to speedup landing this ππΌ |
Hi @sl0wik . Thanks for that fix. It helps me a lot. To be compatible with the latest giget version v1.2.3 your fix need to be updated a little: |
When The |
This comment was marked as off-topic.
This comment was marked as off-topic.
url: `${gitlab}/${parsed.repo}/tree/${parsed.ref}${parsed.subdir}`, | ||
tar: `${gitlab}/${parsed.repo}/-/archive/${parsed.ref}.tar.gz`, | ||
url: `${gitlab}/${parsed.repo}${parsed.subdir}/tree/${parsed.ref}`, | ||
tar: `${gitlab}/${parsed.repo}${parsed.subdir}/-/archive/${parsed.ref}.tar.gz`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is currently generating with //
{
name: 'unjs-template',
version: 'main',
subdir: '/',
headers: { authorization: undefined, 'sec-fetch-mode': 'same-origin' },
url: 'https://gitlab.com/unjs/template//tree/main',
tar: 'https://gitlab.com/unjs/template//-/archive/main.tar.gz'
}
π Linked issue
#107
β Type of change
π Description
Gitlab supports nested subgroups, like
https://gitlab.com/{groupName}/{subgroupName}/{repoName}
. Attempting to pull any subgroup would result in a 403 error. This pull request resolves the issue.π Checklist