feat: add aws-dynamodb driver
#234
Conversation
✅ Live Preview ready!
|
pi0
changed the title
|
Thanks for the PR @daaru00. Checking locally, the types and test are failing. Can you please check? 🙏🏼 |
|
Hello @pi0, May I ask what error message you get? |
Do you think we can mock AWS library to make sure tests run locally? |
|
@pi0 I did a test using the official mock library managed by AWS: https://aws.amazon.com/it/blogs/developer/mocking-modular-aws-sdk-for-javascript-v3-in-unit-tests/. client
.on(GetCommand)
.callsFake(input => {
const key = input.Key.key
if (!data.has(key)) {
return { Item: undefined }
}
return { Item: { key, value: data.get(key) } }
})
.on(ScanCommand)
.callsFake(() => {
return { Items: Array.from(data.entries()).map(([ key, value ]) => ({ key, value })) }
})
.on(PutCommand)
.callsFake(input => {
data.set(input.Item.key, input.Item.value)
})
.on(DeleteCommand)
.callsFake(input => {
data.delete(input.Key.key)
})Is this the expected result? ps: I also had to update the AWS SDK due to some internal conflicts with typescript types |
| ttl?: string; | ||
| }; | ||
| expireIn?: number; | ||
| client?: DynamoDBDocumentClient; |
There was a problem hiding this comment.
Would be nice to have ttl as a top level option here, for consistency with other drivers #262
src/drivers/aws-dynamodb.ts
Outdated
| async getItem(key) { | ||
| return await getItemValue(key); | ||
| }, | ||
| async setItem(key, value) { |
There was a problem hiding this comment.
We could accept, key, value, options with { ttl } in options for per object expiration.
|
what is the timeline for this to be merged into master? |
pi0
changed the title
aws-dynamodb driver
pi0
changed the title
aws-dynamodb driveraws-dynamodb driver
Add support for Amazon DynamoDB.
Also add support for DynamoDB Time to Live (TTL), this is order to manage key expiration.
A note about "aws-dynamodb" driver's tests: they will fail if no valid AWS credentials will be found (using profile or environment variables).