Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(azure-storage-blob): add raw support #565

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

peterbud
Copy link

@peterbud peterbud commented Jan 4, 2025

This PR adds raw item get/set support, similar to abandoned #442, but also adds test for that new procedures.

Also I have noticed that the current removeItem test fails, as delete operation with non-existent keys leads to an error. I assume the intention is not to fail in such cases, so I have not changed the removeItem test, but added a check before attempting to delete the blob at the Azure Blob driver.

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

Attention: Patch coverage is 7.14286% with 26 lines in your changes missing coverage. Please review.

Project coverage is 59.63%. Comparing base (4d61c78) to head (5a56d23).
Report is 160 commits behind head on main.

Files with missing lines Patch % Lines
src/drivers/azure-storage-blob.ts 7.14% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #565      +/-   ##
==========================================
- Coverage   65.05%   59.63%   -5.43%     
==========================================
  Files          39       42       +3     
  Lines        4055     3676     -379     
  Branches      487      590     +103     
==========================================
- Hits         2638     2192     -446     
- Misses       1408     1481      +73     
+ Partials        9        3       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itpropro
Copy link
Member

itpropro commented Jan 6, 2025

Thanks for bringing this up again, I unfortunately missed the PR.
Let me go over the tests to validate we are fine here so we can proceed as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants