fix(PinInput): placeholder not showing after reseting the value progr…

…amatically (#1530) * fix(PinInput): placeholder not showing after reseting the value programatically * test: include test Co-authored-by: antfu <[email protected]>
unovue · Dec 30, 2024 · 2ff8ffe · 2ff8ffe
1 parent ad43ecf
commit 2ff8ffe
Show file tree

Hide file tree

Showing 3 changed files with 47 additions and 7 deletions.
diff --git a/packages/radix-vue/src/PinInput/PinInput.test.ts b/packages/radix-vue/src/PinInput/PinInput.test.ts
@@ -22,6 +22,14 @@ describe('given default PinInput', () => {
     expect(await axe(wrapper.element)).toHaveNoViolations()
   })
 
+  it('should display input placeholders', () => {
+    expect(inputs[0].element.placeholder).toBe('') // first input was focused thus not showing placeholder
+    expect(inputs[1].element.placeholder).toBe('*')
+    expect(inputs[2].element.placeholder).toBe('*')
+    expect(inputs[3].element.placeholder).toBe('*')
+    expect(inputs[4].element.placeholder).toBe('*')
+  })
+
   describe('after user input', () => {
     beforeEach(async () => {
       await userEvent.keyboard('test')
@@ -143,6 +151,22 @@ describe('given default PinInput', () => {
     it('should emit \'complete\' with the result', () => {
       expect(wrapper.emitted('complete')?.[0]?.[0]).toStrictEqual(['a', 'p', 'p', 'l', 'e'])
     })
+
+    describe('after resetting value', async () => {
+      beforeEach(async () => {
+        await userEvent.keyboard('apple')
+        const button = wrapper.find('button')
+        await button.trigger('click')
+      })
+
+      it('should display input placeholders', () => {
+        expect(inputs[0].element.placeholder).toBe('*')
+        expect(inputs[1].element.placeholder).toBe('*')
+        expect(inputs[2].element.placeholder).toBe('*')
+        expect(inputs[3].element.placeholder).toBe('*')
+        expect(inputs[4].element.placeholder).toBe('*')
+      })
+    })
   })
 })
 

diff --git a/packages/radix-vue/src/PinInput/PinInputInput.vue b/packages/radix-vue/src/PinInput/PinInputInput.vue
@@ -12,14 +12,15 @@ export interface PinInputInputProps extends PrimitiveProps {
 </script>
 
 <script setup lang="ts">
-import { computed, nextTick, onMounted, onUnmounted } from 'vue'
+import { computed, nextTick, onMounted, onUnmounted, watch } from 'vue'
 
 const props = withDefaults(defineProps<PinInputInputProps>(), {
   as: 'input',
 })
 
 const context = injectPinInputRootContext()
 const inputElements = computed(() => Array.from(context.inputElements!.value))
+const currentValue = computed(() => context.modelValue.value[props.index])
 
 const disabled = computed(() => props.disabled || context.disabled.value)
 const isOtpMode = computed(() => context.otp.value)
@@ -48,6 +49,14 @@ function handleInput(event: InputEvent) {
     nextEl.focus()
 }
 
+function resetPlaceholder() {
+  const target = currentElement.value as HTMLInputElement
+  nextTick(() => {
+    if (!target.value)
+      target.placeholder = context.placeholder.value
+  })
+}
+
 function handleKeydown(event: KeyboardEvent) {
   useArrowNavigation(event, document.activeElement as HTMLElement, undefined, {
     itemsArray: inputElements.value,
@@ -91,11 +100,7 @@ function handleFocus(event: FocusEvent) {
 }
 
 function handleBlur(event: FocusEvent) {
-  const target = event.target as HTMLInputElement
-  nextTick(() => {
-    if (!target.value)
-      target.placeholder = context.placeholder.value
-  })
+  resetPlaceholder()
 }
 
 function handlePaste(event: ClipboardEvent) {
@@ -142,6 +147,12 @@ function updateModelValueAt(index: number, value: string) {
   context.modelValue.value = removeTrailingEmptyStrings(tempModelValue)
 }
 
+watch(currentValue, () => {
+  if (!currentValue.value) {
+    resetPlaceholder()
+  }
+})
+
 onMounted(() => {
   context.onInputElementChange(currentElement.value as HTMLInputElement)
 })
@@ -161,7 +172,7 @@ onUnmounted(() => {
     :inputmode="isNumericMode ? 'numeric' : 'text'"
     :pattern="isNumericMode ? '[0-9]*' : undefined"
     :placeholder="context.placeholder.value"
-    :value="context.modelValue.value[index]"
+    :value="currentValue"
     :disabled="disabled"
     :data-disabled="disabled ? '' : undefined"
     :data-complete="context.isCompleted.value ? '' : undefined"

diff --git a/packages/radix-vue/src/PinInput/story/_PinInput.vue b/packages/radix-vue/src/PinInput/story/_PinInput.vue
@@ -15,6 +15,7 @@ const value = ref<string[]>([])
   <PinInputRoot
     v-bind="{ ...props, ...useEmitAsProps(emits) }"
     v-model="value"
+    placeholder="*"
     class="flex gap-2 items-center"
   >
     <PinInputInput
@@ -24,4 +25,8 @@ const value = ref<string[]>([])
       :index="index"
     />
   </PinInputRoot>
+
+  <button @click="value = []">
+    Reset value
+  </button>
 </template>