Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PopoverContent): focus trap #1510

Closed
wants to merge 1 commit into from

Conversation

wouterlms
Copy link

No description provided.

@wouterlms wouterlms changed the base branch from main to v2 December 18, 2024 20:18
@zernonia
Copy link
Member

Hi @wouterlms .. do you mind sharing what's the idea behind these changes?

@wouterlms
Copy link
Author

@zernonia I have a use case in a project where I want to disable the focus trap in a popover. I noticed in the docs that there’s a prop for disabling it, but it doesn’t seem to have any effect. This PR addresses that. Or am I misunderstanding, and is it intended not to work?

@zernonia
Copy link
Member

zernonia commented Jan 16, 2025

Ahhh thanks @wouterlms ! I understand the problem here. By right the trapFocus should be internal prop and user should use modal to trap the or untrap the focus, that's why the prop does nothing and confuse you.

I think we should remove it from the docs

@zernonia
Copy link
Member

Closing this as found out the problem is with the internal props being exposed.
Thanks for bringing the issue up and the PR 🙏🏼

6b5af16

@zernonia zernonia closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants