Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix nuxt.config.ts configuration for auto-import components directories #154

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

sadeghbarati
Copy link
Collaborator

Resolve #153

If we use the components key in the nuxt.config.ts default config for directories will removed

default configs 👇

{ priority: 1, path: 'D:/Test/nuxt-test/components/islands', island: true },
{ priority: 1, path: 'D:/Test/nuxt-test/components/global', global: true },
{ priority: 1, path: 'D:/Test/nuxt-test/components' },

Instead, it's better to use components:dirs hook for extending auto-import directories

@sadeghbarati
Copy link
Collaborator Author

For rewording please send me a review

@sadeghbarati sadeghbarati changed the title docs: fix nuxt.config.ts components installiation step docs: fix nuxt.config.ts configuration for auto-import components directories Nov 8, 2023
@sadeghbarati sadeghbarati requested a review from zernonia November 9, 2023 09:34
@zernonia
Copy link
Member

zernonia commented Nov 9, 2023

Thanks @sadeghbarati ! Have you tried and verify that using the hook method works? 😁

@sadeghbarati
Copy link
Collaborator Author

Yes, for the test I'll share a StackBlitz here

@sadeghbarati
Copy link
Collaborator Author

@zernonia

https://stackblitz.com/edit/github-xwksho?file=nuxt.config.ts

Copy link
Member

@zernonia zernonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the stackblitz demo and the PR!

@zernonia zernonia merged commit a2c5834 into unovue:dev Nov 9, 2023
1 check failed
@sadeghbarati sadeghbarati deleted the docs/fix-nuxt-config-step branch November 9, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Nuxt installation steps - add '~/components' to components key (not sure if it's required)
2 participants