Avoid if call in the __parallel_merge_submitter_large::run_parallel_merge()
#1980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avoid if call in the __parallel_merge_submitter_large::run_parallel_merge() Signed-off-by: Sergey Kopienko <[email protected]>
…avoid if call in the __parallel_merge_submitter_large::run_parallel_merge() Signed-off-by: Sergey Kopienko <[email protected]>
…fix compile error Signed-off-by: Sergey Kopienko <[email protected]>
…fix compile error Signed-off-by: Sergey Kopienko <[email protected]>
…fix compile error Signed-off-by: Sergey Kopienko <[email protected]>
| @@ -283,6 +283,15 @@ struct __parallel_merge_submitter_large<_IdType, _CustomName, | |||
| }); | |||
| } | |||
|
|
|||
| template <typename _Rng1, typename _Rng2, typename _Compare> | |||
| inline static _split_point_t<_IdType> | |||
| __find_start_point_w(const _Rng1& __rng1, const _Rng2& __rng2, const _split_point_t<_IdType>& __sp_left, | |||
There was a problem hiding this comment.
What's a purpose of __find_start_point_w? It seems, it does not any additional things, beside re-calling __find_start_point...
Is it fair in case |
Comment on lines
+323
to
+327
| const _split_point_t<_IdType> __start = | ||
| __global_idx % __nd_range_params.steps_between_two_base_diags != 0 | ||
| ? __find_start_point_w(__rng1, __rng2, __base_diagonals_sp_global_ptr[__diagonal_idx], | ||
| __base_diagonals_sp_global_ptr[__diagonal_idx + 1], __i_elem, __comp) | ||
| : __base_diagonals_sp_global_ptr[__diagonal_idx]; |
There was a problem hiding this comment.
From a performance perspective, as far as I know a ternary operator (?) is equivalent to an if statement. Both end up as branches.
Is this PR intended to clean up the code to be improve readability or performance?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we remove additional
ifcall from__parallel_merge_submitter_large::run_parallel_merge()Our experience shows that it should work faster.