Skip to content

Commit

Permalink
Add learnings from Jouni about working with haplotypes that end
Browse files Browse the repository at this point in the history
  • Loading branch information
adamnovak committed Jan 23, 2025
1 parent 933056a commit 05de791
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions src/haplotype_extracter.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,16 @@ Path path_from_thread_t(thread_t& t, const HandleGraph& source);
// then the search stops. The search will also emit a result if any selected sample stops.
//
// No empty sub-haplotypes will be returned.
//
// For haplotypes emitted because a sample stopped, the corresponding GBWT
// search state will have been extended with the end marker. It will have the
// correct .size() for the number of haplotypes that stop there, but it will
// *not* be usable with locate() queries! If you need to do locate() queries,
// you need to filter the output and keep only results that would have
// satisfied the stop_fn predicate.
//
// TODO: Adopt a different internal format that doesn't have such a weird
// quirk.
vector<pair<vector<gbwt::node_type>, gbwt::SearchState> > list_haplotypes(const HandleGraph& graph,
const gbwt::GBWT& gbwt,
handle_t start,
Expand Down

1 comment on commit 05de791

@adamnovak
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vg CI tests complete for branch fix-chunk-haplotypes. View the full report here.

16 tests passed, 0 tests failed and 0 tests skipped in 17241 seconds

Please sign in to comment.