-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSDK-9288: declutter UI #4692
Draft
purplenicole730
wants to merge
13
commits into
viamrobotics:main
Choose a base branch
from
purplenicole730:RSDK-9288-declutter-UI
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
RSDK-9288: declutter UI #4692
purplenicole730
wants to merge
13
commits into
viamrobotics:main
from
purplenicole730:RSDK-9288-declutter-UI
+243
−177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
This pull request is marked safe to test from a trusted zone
label
Jan 8, 2025
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Jan 8, 2025
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Jan 8, 2025
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Jan 8, 2025
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Jan 8, 2025
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Most of the changes can be shown through the following examples.
Before:
command
is unclear if it's supposed to be replaced or not, andarguments
is misleadingAfter: remove
arguments
and highlightcommand
is something to replace:Before: ignores login options and ignores that
command
is optionalAfter: alludes to login options and
command
is now optionalBefore: Incorrectly shows additional options and arguments when there are none
After: Show clear and correct usage
Before: incorrect command name and alludes to nonexistent other options
After: correct way to use command
Before: shows wrong usage of
org-id
flag and ignores subcommandsAfter: correct usage of
logo
without flags and with subcommands. hideshelp
subcommandBefore: Alludes to command options that don't exist, inconsistent org argument
After: add org flag, remove arguments suggestion
Test to make sure: