Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RSDK-9702] - Do not return odd resolutions from GetStreamOptions Response #4693

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

seanavery
Copy link
Member

@seanavery seanavery commented Jan 8, 2025

Description

Although we can resize to odd resolutions this breaks our h264 encoder pipeline. Prevent odd resolutions by rounding down to nearest even.

Testing

Manually tested we no longer return odd resolutions and resize streams are working.

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Jan 8, 2025
@seanavery seanavery changed the title [RSDK-9702] - Fix bug with odd dynamic resolutions [RSDK-9702] - Do not return odd resolutions from GetStreamOptions Response Jan 8, 2025
@seanavery seanavery requested a review from randhid January 8, 2025 18:03
Copy link
Member

@randhid randhid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a test somewhere that tests and retains the behaviour? Can be a unit test just testing that this thing returns what we're expecting, it's a pretty isolated function.

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jan 8, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jan 8, 2025
@seanavery
Copy link
Member Author

@randhid Added test cases to verify we do not get odd dims.

@seanavery seanavery merged commit f6c9e78 into viamrobotics:main Jan 9, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants