Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pod struct in logs #16

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Remove pod struct in logs #16

merged 1 commit into from
Feb 17, 2021

Conversation

Jeffwan
Copy link
Contributor

@Jeffwan Jeffwan commented Jan 25, 2021

Signed-off-by: Jiaxin Shan [email protected]

Address #12

  1. Do not print pod struct in every pod sync loop
  2. Do not print error, this should be catched in error check. only print output after error handling.
  3. Print <namespace/name> in GetPods request when VK provider starts.

@Jeffwan
Remove pod struct in logs
cd95b4e 
Signed-off-by: Jiaxin Shan <[email protected]>
@Jeffwan
Copy link
Contributor Author

Jeffwan commented Jan 25, 2021

/cc @cpuguy83

cpuguy83
cpuguy83 approved these changes Feb 17, 2021
View reviewed changes
Copy link
Collaborator

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83 cpuguy83 merged commit e016876 into virtual-kubelet:master Feb 17, 2021
@Jeffwan Jeffwan deleted the cleanup_logs branch February 17, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jeffwan @cpuguy83