-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(worker): support dynamic worker option fields #19010
Open
jamsinclair
wants to merge
10
commits into
vitejs:main
Choose a base branch
from
jamsinclair:support-dynamic-worker-option-fields
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(worker): support dynamic worker option fields #19010
jamsinclair
wants to merge
10
commits into
vitejs:main
from
jamsinclair:support-dynamic-worker-option-fields
+254
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamsinclair
changed the title
feat(worker): Support dynamic worker option fields
feat(worker): support dynamic worker option fields
Dec 19, 2024
Looks like this change broke the tests in two ways 😅
I'll look into fixing these tomorrow. |
jamsinclair
commented
Dec 20, 2024
jamsinclair
commented
Dec 20, 2024
sapphi-red
added
feat: web workers
p3-significant
High priority enhancement (priority)
labels
Dec 27, 2024
sapphi-red
reviewed
Dec 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I left some minor comments.
packages/vite/src/node/__tests__/plugins/workerImportMetaUrl.spec.ts
Outdated
Show resolved
Hide resolved
sapphi-red
approved these changes
Jan 7, 2025
hi-ogawa
approved these changes
Jan 8, 2025
patak-dev
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Problem
Vite has a hard requirement that worker options are defined statically or it throws an error. This prevents some legitimate use cases, such as when a dynamic name is used to differentiate workers. As seen in the Emscripten project (code reference)
This is causing some issues in trying to update Emscripten to support Vite when workers are in use.
Solution
Vite only needs to ensure that the
type
value is statically defined. Other fields could be dynamically computed with no effect on the Vite bundling process.A side discussion was started in #18396 (comment) about relaxing the usage of some worker option fields to support this.
This PR hopes to solve this issue in a backwards compatible way that still ensures that Vite can have high confidence in asserting the worker type at compile time.