Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TPU][CI] Update torchxla version in requirement-tpu.txt #12422

Merged

Conversation

lsy323
Copy link
Contributor

@lsy323 lsy323 commented Jan 24, 2025

This is a follow up PR of #12334.

In the current CI setup, we use a nightly torch_xla docker image on a specific day as the base image, then run pip install -r requirements-tpu.txt to install all the TPU dependency packages. However, requirements-tpu.txt includes the nightly torch_xla pinned on a specific day, and it will overwrite the one in the nightly container.

In #12334, the torch_xla version in requirements-tpu.txt wasn't updated so that CI is still using the old torch_xla nightly. In this PR, the nightly version in requirements-tpu.txt is updated.

Maybe it's redundant to use a nightly docker on a specific date as the base image, because the nightly torch_xla in the docker image will be overwritten anyway. This should unblock #12294.

Next step:

  • Use a stable base image for TPU CI, instead of a nightly docker. Or other potential way to avoid confusion.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@lsy323 lsy323 force-pushed the lsiyuan/update-torchxla-version branch from a0086ca to 19dd5b8 Compare January 24, 2025 20:11
@mergify mergify bot added the ci/build label Jan 24, 2025
@lsy323
Copy link
Contributor Author

lsy323 commented Jan 24, 2025

@lsy323 lsy323 force-pushed the lsiyuan/update-torchxla-version branch from 19dd5b8 to aded621 Compare January 24, 2025 23:02
@bvrockwell
Copy link
Contributor

Thanks @lsy323 ! Going to just loop in @richardsliu who worked on the original PR that cleaned up a lot of the req file and docs.

@lsy323 lsy323 force-pushed the lsiyuan/update-torchxla-version branch from aded621 to 15437dc Compare January 25, 2025 02:04
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) January 25, 2025 04:21
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 25, 2025
@DarkLight1337 DarkLight1337 merged commit 324960a into vllm-project:main Jan 25, 2025
83 of 84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants