-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Chinese docs translation #2552
Conversation
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks for the PR @DDDDD12138 ! As I don't understand Chinese, I'll try to find someone on the team who can proof-read this. |
Thanks for the contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, after reviewing some docs, I've found quite a lot of formatting issues. I would recommend you to refer to this Chinese translation guide for more details. And in practice, you can feel free to run zhlint, the tool we use for Vue Chinese docs, on your translation files. Usually for most of the issues, this tool can help you to figure them out and fix them. We can discuss further if you have any questions in any particular cases.
After solving the formatting issues, we can merge it ahead (probably with a "in review" marks on the pages somewhere) and then review the docs piece by piece as the second step.
Thanks.
ok, I'll deal with it later. |
76a5cd8
to
25bdbe6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
优化描述更改中文斜体用法
Co-authored-by: veaba <[email protected]>
801e73a
to
638839b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
文件太大没法加 sug,斜体使用
另外补充:vue-router.md L289 部分。
```suggestion
然而,在这种情况下,我们没有可以等待的 *hasNavigated* 钩子。一种替代方法是使用从 Vue Test Utils 导出的 `flushPromises` 函数:
添加太大 500 了。
e7b47de
to
1af49f3
Compare
Co-authored-by: veaba <[email protected]> Co-authored-by: Jinjiang <[email protected]>
1af49f3
to
e6c7f41
Compare
这个指的是啥?我这边好像没显示出来🤔 |
那个 vue-router.md 文件太大,没办法对指定位置添加 Suggetion,Github 报 500了。 改动部位: @Jinjiang 我这边 review 结束了,再交叉检查下应该可以了。 |
I've added these in-review labels and created this epic issue #2561 for further review. For this PR I will merge soon. Thanks all. |
Description
Add Chinese documentation, detailed comparison with the original English can be found in this commit.
Preview