Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Chinese docs translation #2552

Merged
merged 17 commits into from
Dec 5, 2024
Merged

Conversation

DDDDD12138
Copy link
Contributor

Description

Add Chinese documentation, detailed comparison with the original English can be found in this commit.

Preview

image
image
image

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for vue-test-utils-docs ready!

Name Link
🔨 Latest commit 0568d3b
🔍 Latest deploy log https://app.netlify.com/sites/vue-test-utils-docs/deploys/67517b874b2975000897c4b7
😎 Deploy Preview https://deploy-preview-2552--vue-test-utils-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cexbrayat
Copy link
Member

Thanks for the PR @DDDDD12138 !

As I don't understand Chinese, I'll try to find someone on the team who can proof-read this.

@Jinjiang
Copy link
Member

Thanks for the contribution!
Update: I'm calling @vuejs-translations zh-cn team to review this PR.

Copy link
Member

@Jinjiang Jinjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, after reviewing some docs, I've found quite a lot of formatting issues. I would recommend you to refer to this Chinese translation guide for more details. And in practice, you can feel free to run zhlint, the tool we use for Vue Chinese docs, on your translation files. Usually for most of the issues, this tool can help you to figure them out and fix them. We can discuss further if you have any questions in any particular cases.

After solving the formatting issues, we can merge it ahead (probably with a "in review" marks on the pages somewhere) and then review the docs piece by piece as the second step.

Thanks.

docs/zh/README.md Outdated Show resolved Hide resolved
@DDDDD12138
Copy link
Contributor Author

ok, I'll deal with it later.

docs/zh/guide/essentials/a-crash-course.md Outdated Show resolved Hide resolved
docs/zh/guide/advanced/async-suspense.md Outdated Show resolved Hide resolved
Copy link
Member

@veaba veaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

优化描述更改中文斜体用法

docs/zh/guide/advanced/async-suspense.md Outdated Show resolved Hide resolved
docs/zh/guide/advanced/async-suspense.md Outdated Show resolved Hide resolved
docs/zh/guide/advanced/async-suspense.md Outdated Show resolved Hide resolved
docs/zh/guide/advanced/http-requests.md Outdated Show resolved Hide resolved
Copy link
Member

@veaba veaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文件太大没法加 sug,斜体使用

另外补充:vue-router.md L289 部分。
```suggestion
然而,在这种情况下,我们没有可以等待的 *hasNavigated* 钩子。一种替代方法是使用从 Vue Test Utils 导出的 `flushPromises` 函数:

添加太大 500 了。

docs/zh/migration/index.md Outdated Show resolved Hide resolved
docs/zh/guide/advanced/reusability-composition.md Outdated Show resolved Hide resolved
@DDDDD12138 DDDDD12138 force-pushed the feat-zh-locale branch 2 times, most recently from e7b47de to 1af49f3 Compare December 4, 2024 07:04
Co-authored-by: veaba <[email protected]>
Co-authored-by: Jinjiang <[email protected]>
@DDDDD12138
Copy link
Contributor Author

添加太大 500 了。

这个指的是啥?我这边好像没显示出来🤔

@veaba
Copy link
Member

veaba commented Dec 4, 2024

添加太大 500 了。

这个指的是啥?我这边好像没显示出来🤔

那个 vue-router.md 文件太大,没办法对指定位置添加 Suggetion,Github 报 500了。

改动部位:_hasNavigated_ 改为 *hasNavigated* 就可以了。

@Jinjiang 我这边 review 结束了,再交叉检查下应该可以了。

@Jinjiang
Copy link
Member

Jinjiang commented Dec 5, 2024

image

I've added these in-review labels and created this epic issue #2561 for further review.

For this PR I will merge soon. Thanks all.

@Jinjiang Jinjiang merged commit 3640951 into vuejs:main Dec 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants