Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf!: use passive event handlers everywhere is possible #4477

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ferferga
Copy link
Contributor

@ferferga ferferga commented Jan 9, 2025

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

Use passive event handlers wherever original DOM events are used.

Additional context

See my code comment as to why this PR is labeled as having breaking changes, despite at the surface not breaking anything.

Since Vue 2 support has been dropped already, and all browsers supporting Proxy (requirement imposded by Vue 3) already has passive event support, having this polyfill is unnecessary and we can assume support.

Also, in some other places, passive event handlers were being used already.
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 9, 2025
@@ -153,7 +142,6 @@ export function useSwipe(
const stop = () => stops.forEach(s => s())

return {
isPassiveEventSupported,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the reason why this PR is labeled as a blocking change. I think not many people is using this (since passive event support is almost ubiquituos) and the main purpose of the polyfill was to being used inside the composable itself, but it's a change regardless. Thoughts?

As I indicated in my commit message:


Since Vue 2 support has been dropped already, and all browsers supporting Proxy (requirement imposded by Vue 3) already has passive event support, having this polyfill is unnecessary and we can assume support.

Also, in some other places, passive event handlers were being used already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant