Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[venom]: improve load elimination #4407

Draft
wants to merge 33 commits into
base: master
Choose a base branch
from

Conversation

charles-cooper
Copy link
Member

What I did

follow up to #4265 but generalize the lattice to multiple keys

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@charles-cooper charles-cooper force-pushed the feat/advanced-load-elimination branch from f57aab3 to 0155857 Compare December 20, 2024 20:13
@charles-cooper charles-cooper changed the title Feat/advanced load elimination feat[venom]: improve load elimination Dec 20, 2024
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 8.51064% with 43 lines in your changes missing coverage. Please review.

Project coverage is 57.67%. Comparing base (db8dcc7) to head (55cbf90).

Files with missing lines Patch % Lines
vyper/venom/passes/load_elimination.py 8.88% 41 Missing ⚠️
vyper/venom/__init__.py 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (db8dcc7) and HEAD (55cbf90). Click for more details.

HEAD has 31 uploads less than BASE
Flag BASE (db8dcc7) HEAD (55cbf90)
141 110
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4407       +/-   ##
===========================================
- Coverage   92.01%   57.67%   -34.35%     
===========================================
  Files         119      119               
  Lines       16692    16724       +32     
  Branches     2805     2812        +7     
===========================================
- Hits        15359     9645     -5714     
- Misses        915     6400     +5485     
- Partials      418      679      +261     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants