Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log parsing #883

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Conversation

hagenmt
Copy link

@hagenmt hagenmt commented Nov 1, 2023

by injecting extra double quotes here it break json logging and causes errors like this in fluentd:

pattern not matched message="{\"timestamp\":\"2023-10-28T14:01:56.949Z\",\"logger\":\"com.wavefront.agent.listeners.AbstractPortUnificationHandler\",\"region\":\"region-x\",\"hostname\":\"xxx-xxxx-xxxx\",\"service\":\"vmc-wavefront-proxy\",\"app_id\":\"vmc-wavefront-proxy\",\"commit\":\"\",\"build\":\"0.1.0-20231004-252-5ca6a9a\",\"level\":\"WARN\",\"thread\":\"epollEventLoopGroup-17-7\",\"marker\":\"\",\"exception\":\"\",\"message\":\"Received line is too long, consider increasing pushListenerMaxReceivedLength; remote: x.x.x.x [30000]; reason: \"frame length (18463928) exceeds the allowed maximum (1048576)\"\",\"mdc\":\"{}\",\"component\":\"\",\"sub_component\":\"\",\"sddc_id\":\"\",\"org_id\":\"\",\"op_id\":\"\"}"

and from the CLI the log looks like this with extra double quotes:

2023-10-28 12:02:37,176 WARN  [AbstractPortUnificationHandler:logWarning] Received line is too long, consider increasing pushListenerMaxReceivedLength; remote: x.x.x.x [30000]; reason: "frame length (18468978) exceeds the allowed maximum (1048576)"

@hagenmt
Copy link
Author

hagenmt commented Nov 1, 2023

pls review:
@laullon
@joannak-vmware

Copy link
Contributor

@zen10001 zen10001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@joannatk joannatk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants