Fixes _types generation and modernizes module resolution.
#56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the `_types` is built using `node` module resolution, which results in this project generating invalid types. Details about the TypeScript bug can be found at microsoft/TypeScript#60930 (comment) and there are no plans to fix it since `node` (which is equivalent to `node10`) is being deprecated in TypeScript soon. The way this bug manifests is in files like `src/_types/core/P256.d.ts` where it would previously generate code like:�```ts create: (hash: import("@noble/curves/abstract/utils.js").CHash) => import("@noble/curves/abstract/weierstrass.js").CurveFn; ``` when it should have generated code like this (which is what is generated after this change):�```ts create: (hash: import("@noble/curves/abstract/utils").CHash) => import("@noble/curves/abstract/weierstrass").CurveFn; ``` For the cjs build command, I changed from `node` to `node10` to be more explicit/clear, since `node` was just an alias for `node10`. For the esm build command, I changed it to use the tsconfig so it is less likely to get out of sync with the generated types. Also updated .gitignore to ignore `.pnpm-store` which had 30,000 files it wanted to commit after I did `pnpm install` using the recommended version of `pnpm`.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
_typesis built usingnodemodule resolution, which results in this project generating invalid types. Details about the TypeScript bug can be found at microsoft/TypeScript#60930 (comment) and there are no plans to fix it sincenode(which is equivalent tonode10) is being deprecated in TypeScript soon.The way this bug manifests is in files like
src/_types/core/P256.d.tswhere it would previously generate code like:when it should have generated code like this (which is what is generated after this change):
For the cjs build command, I changed from
nodetonode10to be more explicit/clear, sincenodewas just an alias fornode10.For the esm build command, I changed it to use the tsconfig so it is less likely to get out of sync with the generated types.
Also updated .gitignore to ignore
.pnpm-storewhich had 30,000 files it wanted to commit after I didpnpm installusing the recommended version ofpnpm.