Use the basic URL parser when parsing URLs #248
Conversation
Blob handling is not required, since the resulting URL is not stored in any way that would make the blob handling visible. This is consistent with what the URL constructor and similar uses do. This change should not be observable. Partially addresses whatwg#242.
|
This is not quite editorial but close to it as I think it's more or less just clarification and simplification. |
|
@shannonbooth I think this should address your first comment in #242, right? @sisidovski Please review. |
|
Yup, this fixes that portion of the issue, thanks! Though I will mention that the HTML spec uses the language: "basic URL parse" in text to differentiate the two types of parsing so that the reader can know which one is called without needing to navigate to the spec link (the difference in language here - lack of "basic") is what made me notice the issue). So I personally think it would be nice to specifically say "basic URL parse" or similar, which would also be consistent with the canonicalization steps (e.g https://urlpattern.spec.whatwg.org/#canonicalize-a-protocol) |
|
Fair, I'll use "running the basic URL parser on url [with base]" wording as used elsewhere here and in the URL living standard. |
Blob handling is not required, since the resulting URL is not stored in any way that would make the blob handling visible. This is consistent with what the URL constructor and similar uses do.
This change should not be observable.
Partially addresses #242.
Preview | Diff