Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Revamp dataSet in Tales to account for raw data #502

Closed
wants to merge 16 commits into from

Conversation

Xarthisius
Copy link
Collaborator

@Xarthisius Xarthisius commented Sep 7, 2021

Arguably this work should be submitted as multiple PRs, but I was lazy...

Roughly what it does:

  1. Introduces "Tale's data directory" see: https://hackmd.io/KQ9TzJ7zSrqzaeYGX9ClSQ
  2. Abstracts Zip upload handling from BDBag importer
  3. Adds generic zip provider that allows to dump raw data in to Tale's data directory
  4. Handles existing catalog resources via Tale's datadir

What should work:

What doesn't work:

  • importing
  • tests

more info tba

@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #502 (4f65df9) into master (2e2ae35) will decrease coverage by 0.60%.
The diff coverage is 84.94%.

❗ Current head 4f65df9 differs from pull request most recent head a57b38b. Consider uploading reports for the commit a57b38b to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #502      +/-   ##
==========================================
- Coverage   93.41%   92.81%   -0.61%     
==========================================
  Files          54       54              
  Lines        4179     4243      +64     
==========================================
+ Hits         3904     3938      +34     
- Misses        275      305      +30     
Impacted Files Coverage Δ
server/schema/tale.py 100.00% <ø> (ø)
server/lib/bdbag/bdbag_provider.py 79.33% <62.96%> (-12.50%) ⬇️
server/lib/manifest.py 91.50% <66.66%> (-0.57%) ⬇️
server/rest/dataset.py 87.31% <80.00%> (-0.79%) ⬇️
server/lib/globus/globus_provider.py 65.48% <91.66%> (+1.67%) ⬆️
server/models/tale.py 97.01% <94.44%> (-1.09%) ⬇️
server/constants.py 88.63% <100.00%> (+0.26%) ⬆️
server/lib/__init__.py 96.07% <100.00%> (+0.07%) ⬆️
server/lib/dataone/provider.py 97.05% <100.00%> (+0.23%) ⬆️
server/lib/dataverse/provider.py 97.34% <100.00%> (+0.06%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1639360...a57b38b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant