Move repluggableAppDebug to use globalThis (#268)

wix-incubator · Jan 28, 2025 · c0418a2 · c0418a2
1 parent 21fdf5f
commit c0418a2
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 11 deletions.
diff --git a/.yarn/install-state.gz b/.yarn/install-state.gz
diff --git a/src/hot.ts b/src/hot.ts
@@ -18,11 +18,11 @@ export function hot(sourceModule: any, entryPoints: EntryPoint[], host?: AppHost
     }
 
     const getHostInstance = () => {
-        const hostInstance = host ?? window.repluggableAppDebug?.host
+        const hostInstance = host ?? globalThis.repluggableAppDebug?.host
         if (!hostInstance) {
             console.error(
                 `HMR error: cannot find host object.\n` +
-                    `hot(...) was called without the optional host parameter, and the fallback window.repluggableAppDebug.host doesn't exist`
+                    `hot(...) was called without the optional host parameter, and the fallback globalThis.repluggableAppDebug.host doesn't exist`
             )
         }
 

diff --git a/src/repluggableAppDebug/debug.d.ts b/src/repluggableAppDebug/debug.d.ts
@@ -3,9 +3,8 @@ import { AnyExtensionSlot } from '../extensionSlot'
 import { Hot } from '../hot'
 
 declare global {
-    interface Window {
-        repluggableAppDebug: RepluggableAppDebugInfo
-    }
+    // Have to use var is this variable reassigned in the global scope
+    var repluggableAppDebug: RepluggableAppDebugInfo
 }
 
 export interface RepluggableAppDebugInfo {

diff --git a/src/repluggableAppDebug/repluggableAppDebug.ts b/src/repluggableAppDebug/repluggableAppDebug.ts
@@ -42,8 +42,8 @@ function mapApiToEntryPoint(allPackages: EntryPoint[]) {
  */
 const getAllEntryPoints = () => {
     return [
-        ...window.repluggableAppDebug.utils.unReadyEntryPoints(),
-        ...[...window.repluggableAppDebug.addedShells].map(([_, shell]) => shell.entryPoint)
+        ...globalThis.repluggableAppDebug.utils.unReadyEntryPoints(),
+        ...[...globalThis.repluggableAppDebug.addedShells].map(([_, shell]) => shell.entryPoint)
     ]
 }
 
@@ -172,11 +172,11 @@ export function setupDebugInfo({
         performance: getPerformanceDebug(options, trace, memoizedArr)
     }
 
-    if (typeof window === 'undefined') {
+    if (typeof globalThis === 'undefined') {
         return
     }
 
-    window.repluggableAppDebug = {
+    globalThis.repluggableAppDebug = {
         host,
         uniqueShellNames,
         extensionSlots,

diff --git a/test/repluggableAppDebug.spec.ts b/test/repluggableAppDebug.spec.ts
@@ -4,7 +4,7 @@ const unreadAPI = { name: 'unreadyAPI' }
 
 const getUnreadyAPIs = async () => {
     await new Promise(resolve => setTimeout(resolve, 0))
-    return window.repluggableAppDebug.utils.getRootUnreadyAPI()
+    return globalThis.repluggableAppDebug.utils.getRootUnreadyAPI()
 }
 
 describe('RepluggableAppDebug', () => {

diff --git a/testKit/index.tsx b/testKit/index.tsx
@@ -90,7 +90,7 @@ export async function createAppHostAndWaitForLoading(packages: EntryPointOrPacka
 
     const timeoutPromise = new Promise((resolve, reject) => {
         setTimeout(() => {
-            const readyAPIs = Array.from(window.repluggableAppDebug.readyAPIs)
+            const readyAPIs = Array.from(globalThis.repluggableAppDebug.readyAPIs)
             const unreadyAPIs = declaredAPIs.filter(api => !readyAPIs.some(readyAPI => readyAPI.name === api.name))
             reject(
                 new Error(