-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arePropsEqualFuncWrapper #254
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noacoWix
changed the title
wrapWithShouldUpdateExperimental WIP
arePropsEqualFuncWrapper WIP
Jul 15, 2024
noacoWix
commented
Jul 15, 2024
itsh01
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix
@shirlynwix I split the test into 3 smaller tests in hope to make it more clear. Let me know what you think. |
shirlynwix
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
In Redux, the calculation of the
mergedProps
depends on determining whetherownProps
have changed. IfownProps
change whileshouldComponentUpdate
is blocking the recalculation ofmergedProps
, a subsequent state update or propagation of seemingly unchangedownProps
(which appear the same as the lastownProps
but differ from theownProps
before the blocking period) may result in incorrectmergedProps
calculation. This issue arises because changes inownProps
during the blocking period are not taken into account.Solution
This PR introduces a mechanism to detect changes in
ownProps
that occur whileshouldComponentUpdate
optimization is in effect. If such changes are detected during this blocking period, the next permitted component update will trigger a recalculation ofmergedProps
considering the updatedownProps
.Additional Information
For more details on how Redux calculates
mergedProps
and the role ofareOwnPropsEqual
in this process, please refer to the following link: Redux - selectorFactory.ts