Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add missing bracket in example #1367

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Conversation

rxliuli
Copy link
Contributor

@rxliuli rxliuli commented Jan 24, 2025

As shown in the picture, a bracket is missing, quickly submit a PR to fix it.

image

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit e3fb765
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/679377b98fe77b0008c2782d
😎 Deploy Preview https://deploy-preview-1367--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Timeraa Timeraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, idk about the format/lint though

@rxliuli
Copy link
Contributor Author

rxliuli commented Jan 25, 2025

Changes look good, idk about the format/lint though

When submitting, lint automatically did some formatting. Do I need to disable automatic formatting and submit again? Speaking of which, if it's not needed, why is there this lint?


I checked, and other places are also in this format. Maybe the previous modifications didn't go through lint-stage?
image

Copy link
Collaborator

@aklinker1 aklinker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't formatted before because of the syntax error (missing }). So now that it's valid JS, it was able to format it. That's how it's supposed to work.

@aklinker1 aklinker1 changed the title docs: Fix a document error. docs: Add missing bracket in example Jan 25, 2025
Copy link

pkg-pr-new bot commented Jan 25, 2025

Open in Stackblitz

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@1367

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@1367

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@1367

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@1367

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@1367

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@1367

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@1367

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@1367

wxt

npm i https://pkg.pr.new/wxt@1367

commit: e3fb765

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.02%. Comparing base (a205f2a) to head (e3fb765).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1367      +/-   ##
==========================================
- Coverage   81.34%   81.02%   -0.32%     
==========================================
  Files         128      128              
  Lines        6288     6288              
  Branches     1072     1068       -4     
==========================================
- Hits         5115     5095      -20     
- Misses       1158     1178      +20     
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 merged commit ac7b676 into wxt-dev:main Jan 25, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants