Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS Fix: allow string | number on StoreFilterField.width prop #3520

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

cnrudd
Copy link
Member

@cnrudd cnrudd commented Nov 3, 2023

TS Fix: allow "string | number", not just "number" on StoreFilterField "width" prop, since underlying TextInput in desktop and mobile takes "string | number" for "width". A string width like '100%' can be useful when the StoreFilterField is the only field in a narrow "picker" grid's toolbar, and you want the field's width to adjust with the user's adjustment of the grid panel width, so that the field's clear button always stays visible.

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry:not required, just a TS fix
  • Reviewed for breaking changes: not a breaking change
  • Updated doc comments / prop-types: docs updated
  • Reviewed and tested on Mobile: reviewed, testing not required.
  • Created Toolbox branch: not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

…d width prop, since underlying TextInput in desktop and mobile takes "string | number" for width.
@cnrudd cnrudd requested review from amcclain and lbwexler November 3, 2023 17:21
@cnrudd cnrudd changed the title TS Fix: allow "string | number", not just "number" on StoreFilterField "width" prop, since underlying TextInput in desktop and mobile takes "string | number" for "width". TS Fix: allow string | number, not just number on StoreFilterField "width" prop, since underlying TextInput in desktop and mobile takes "string | number" for "width". Nov 3, 2023
@cnrudd cnrudd changed the title TS Fix: allow string | number, not just number on StoreFilterField "width" prop, since underlying TextInput in desktop and mobile takes "string | number" for "width". TS Fix: allow string | number, not just number on StoreFilterField width prop, since underlying TextInput in desktop and mobile takes string | number Nov 3, 2023
@cnrudd cnrudd changed the title TS Fix: allow string | number, not just number on StoreFilterField width prop, since underlying TextInput in desktop and mobile takes string | number TS Fix: allow string | number, not just number on StoreFilterField width prop Nov 3, 2023
@lbwexler lbwexler merged commit 00d3918 into develop Nov 3, 2023
@lbwexler lbwexler deleted the storeFilterFieldWidthTs branch November 3, 2023 18:32
@amcclain amcclain changed the title TS Fix: allow string | number, not just number on StoreFilterField width prop TS Fix: allow string | number on StoreFilterField.width prop Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants