Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-grid-layout 1.4.3 -> 1.5.0 #3880

Merged
merged 3 commits into from
Dec 30, 2024
Merged

Conversation

ghsolomon
Copy link
Contributor

@ghsolomon ghsolomon commented Dec 30, 2024

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

@ghsolomon
Copy link
Contributor Author

Replaces #3546

@lbwexler
Copy link
Member

where does the default of 10 come from was that installed by RGL? should we implement/document on the model for clarity

@ghsolomon
Copy link
Contributor Author

ghsolomon commented Dec 30, 2024

where does the default of 10 come from was that installed by RGL? should we implement/document on the model for clarity

RGL's default is containerPadding = margin = [10, 10]. I'll fix to remain consistent with what they're doing.

@ghsolomon
Copy link
Contributor Author

Closes #3526

@lbwexler lbwexler merged commit 79e9633 into develop Dec 30, 2024
2 checks passed
@lbwexler lbwexler deleted the reactGridLayoutUpgrade1.5.0 branch December 30, 2024 23:10
@ghsolomon ghsolomon linked an issue Dec 30, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update reactGridLayout → 1.4.4
2 participants