Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Ruby 3.3 support #200

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Adds Ruby 3.3 support #200

merged 2 commits into from
Jan 31, 2025

Conversation

boimw
Copy link
Contributor

@boimw boimw commented Jan 30, 2025

In this pull request we're adding support for ruby-3.3.

@boimw
Copy link
Contributor Author

boimw commented Jan 30, 2025

Hey @matthewshafer 👋

could you please review this pull request?


question: I'm wondering if we should drop the support for ruby-2.6 and ruby-2.7?

@matthewshafer
Copy link
Collaborator

I can fix the other issues with tests and then rerun CI with this change.

@matthewshafer matthewshafer merged commit a1c6edb into yammer:main Jan 31, 2025
8 checks passed
@matthewshafer
Copy link
Collaborator

Thanks for the PR @boimw

@matthewshafer
Copy link
Collaborator

matthewshafer commented Jan 31, 2025

question: I'm wondering if we should drop the support for ruby-2.6 and ruby-2.7?

That's probably something I'll do whenever we need to release a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants