Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproducing results of "Understanding the Role of the Projector in Knowledge Distillation" #446

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

roymiles
Copy link
Contributor

I have reproduced the results in the original paper. The original paper reports an accuracy of 71.63%, while this config leads to 71.65%.

The log and checkpoint for this run can be found here: https://drive.google.com/drive/folders/18xl0CDZ6CioP4Sbjdpj1Pndp4biSLpnV?usp=sharing

Trained on a single GPU.

@yoshitomo-matsubara yoshitomo-matsubara self-requested a review March 23, 2024 02:56
@@ -0,0 +1,200 @@
datasets:
&imagenet_train ilsvrc2012/train: !import_call
_name: &dataset_name 'imagenet2012'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for consistency with existing files, could you replace 'imagenet2012' in this line with 'ilsvrc2012'?

Copy link
Owner

@yoshitomo-matsubara yoshitomo-matsubara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @roymiles

Beside the above request, I have a few more minor requests:

Thanks!

(Just for a record, roymiles/Simple-Recipe-Distillation#1)

@yoshitomo-matsubara
Copy link
Owner

Thanks @roymiles for the updates!

Did you use 3 GPUs for distributed training? If nos, I will remove the section from README later, when I make minor changes.
https://github.com/yoshitomo-matsubara/torchdistill/pull/446/files#diff-1ecd33e0a6aeb10ddebfcdc6ed245a3e8ea60e38a09ed8974047a3101ec638aeR41-R53

@roymiles
Copy link
Contributor Author

Ah oops, I must have overlooked that. Yea I only used 1 GPU.

@yoshitomo-matsubara
Copy link
Owner

No problem, I will merge this PR and make some modifications.
The next version of torchdistill will be released in a few days, and I will upload the checkpoint and log as part of the release note for backup.

It's a great job! Thanks for your contribution!

@yoshitomo-matsubara yoshitomo-matsubara merged commit af96172 into yoshitomo-matsubara:main Mar 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants