-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for HTTP clients #1084
Open
TwentyPast4
wants to merge
40
commits into
zaphoyd:develop
Choose a base branch
from
TroniusGaming:master
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Support for HTTP clients #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added comparison operator for uri
…loak-in-jackpot-server-and-client feat(jackpot): Support keycloak in jackpot server and client (SW-1007)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going over the available library options, I noticed there's no good pick for having both HTTP and WS in both client and server roles, which were developed to a point where it would be nice to use. I guess boost beast was closest.
Websocketpp is great - and written such that I could relatively easily add HTTP client support to it.
That said, this implementation is not perfect and was tailored to my specific use cases, so the PR might include other changes which might not be directly related or desired. I'm opening the PR for the purpose of presenting a working example on how it could be done and to signal the need for such a feature. Feel free to suggest changes in written form or commit form here or the source repo respectively.