-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add log view #253
Open
Johannes-Thiel
wants to merge
31
commits into
main
Choose a base branch
from
log-view
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add log view #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
while migrating the configs the config for f10 was lost. This is a restoration of the config
For now I just copied the config of F18. For F19 the weeding tool needs to be removed --------- Co-authored-by: Johannes-Thiel <[email protected]>
We will add GNSS code to Rosys in zauberzeug/rosys#231 and this PR implements it for this repo. ToDos: - [x] Add Kalman Filter from #198 - [ ] Wait for [Rosys 0.22.0](https://github.com/zauberzeug/rosys/milestones) with zauberzeug/rosys#242 Migration Guide: 1. In your Septentrio GNSS Module change the NMEA/SBF OUT messages from GGA+GNS+HDT to GGA+GST+HRP. 2. With the field friend container shut down, rename the extrinsics frame_id of the camera calibration from _rosys.odometer.prediction_ to _field_friend.robot_locator_ (~/.rosys/field_friend.vision.calibratable_usb_camera_provider.json) --------- Co-authored-by: Falko Schindler <[email protected]>
When running an automation we want to make sure the detector is running. If the detector is not sending detections for one second, there will be a warning.
We changed the f14 and f15 back to rb37 and rb39. To be consistent the config name was changed
Removing the old obsolete camera config file. These configs can be found in the camera config files of the individual robots.
We will add GNSS code to Rosys in zauberzeug/rosys#231 and this PR implements it for this repo. ToDos: - [x] Add Kalman Filter from #198 - [ ] Wait for [Rosys 0.22.0](https://github.com/zauberzeug/rosys/milestones) with zauberzeug/rosys#242 Migration Guide: 1. In your Septentrio GNSS Module change the NMEA/SBF OUT messages from GGA+GNS+HDT to GGA+GST+HRP. 2. With the field friend container shut down, rename the extrinsics frame_id of the camera calibration from _rosys.odometer.prediction_ to _field_friend.robot_locator_ (~/.rosys/field_friend.vision.calibratable_usb_camera_provider.json) --------- Co-authored-by: Falko Schindler <[email protected]>
pascalzauberzeug
requested changes
Jan 23, 2025
pascalzauberzeug
assigned pascalzauberzeug and Johannes-Thiel and unassigned pascalzauberzeug
Jan 23, 2025
pascalzauberzeug
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Johannes-Thiel I made some changes to bring it into line with the other new development ui elements, since we're trying to move away from the different blue blocks.
- Combine LogView and LogMonitor to one class with a ui function
- Give it a fixed size and its own row to avoid it jumping around
You can merge if you're okay with the changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR the rosys.notify were reviewed and fixed. The Log view was added to the /dev page. This showes up to 100 past notifications.