-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom creation date #41
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add optional creation date and check if it is a valid date
Allow to set custom creation date everywhere
- minor typing fixes -improve test speed
NiklasNeugebauer
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add possibility to set a custom creation date when running detections or uploading images.
This PR slightly exploded because I stumbled across the following issue:
the nodelib used a dataclass "Detections" which was used by the trainer when uploading detections and by the detector when uploading pairs of images and detections.
However, this is not correct because two different EPs are accessed. While both of them require detections, the image_upload also deals with image metadata such as the creation date of THE IMAGE, tags and the source field.
The other one takes detections and a single other field image_id to assign the detections to the correct image.
Before, a mixture of those two structures was used which I found completely confusing, lazy and wrong.
So I fixed this which leads to a breaking change of the library because detectors should from now on use the data structure "ImageMetadata"