Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom creation date #41

Merged
merged 17 commits into from
Nov 12, 2024
Merged

Custom creation date #41

merged 17 commits into from
Nov 12, 2024

Conversation

denniswittich
Copy link
Contributor

@denniswittich denniswittich commented Nov 8, 2024

Add possibility to set a custom creation date when running detections or uploading images.

This PR slightly exploded because I stumbled across the following issue:
the nodelib used a dataclass "Detections" which was used by the trainer when uploading detections and by the detector when uploading pairs of images and detections.

However, this is not correct because two different EPs are accessed. While both of them require detections, the image_upload also deals with image metadata such as the creation date of THE IMAGE, tags and the source field.
The other one takes detections and a single other field image_id to assign the detections to the correct image.

Before, a mixture of those two structures was used which I found completely confusing, lazy and wrong.

So I fixed this which leads to a breaking change of the library because detectors should from now on use the data structure "ImageMetadata"

@denniswittich denniswittich removed the request for review from NiklasNeugebauer November 8, 2024 15:29
@NiklasNeugebauer NiklasNeugebauer merged commit 9d0ab0e into main Nov 12, 2024
3 checks passed
@NiklasNeugebauer NiklasNeugebauer deleted the custom-creation-date branch November 12, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants