chore(rules)!: adds new rules missed in v31 #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Francois-Esquire
approved these changes
Feb 1, 2023
jzempel
requested changes
Feb 1, 2023
plugins/typescript-semantics.js
Outdated
| @@ -18,11 +18,17 @@ module.exports = { | |||
| 'no-return-await': 0, | |||
| 'no-throw-literal': 0, | |||
| 'require-await': 0, | |||
| 'key-spacing': 0, | |||
There was a problem hiding this comment.
[nit] please keep this alphabetically sorted
plugins/react.js
Outdated
| @@ -19,6 +19,13 @@ module.exports = { | |||
| } | |||
| }, | |||
| rules: { | |||
| // enforces using semantic DOM elements over the ARIA role property. | |||
| 'jsx-a11y/prefer-tag-over-role': 0, | |||
There was a problem hiding this comment.
This rule is important to Garden and should be set to 2 error due to the first rule of ARIA
plugins/react.js
Outdated
| @@ -118,7 +125,7 @@ module.exports = { | |||
| // prevent JSX prop spreading | |||
| 'react/jsx-props-no-spreading': 0, | |||
| // enforce default props alphabetical sorting | |||
| 'react/jsx-sort-default-props': 0, | |||
| 'react/sort-default-props': 0, | |||
There was a problem hiding this comment.
[nit] please cut/past to retain alphabetical sorting
plugins/typescript-semantics.js
Outdated
Comment on lines
28
to
31
| '@typescript-eslint/key-spacing': [2, { | ||
| beforeColon: false, | ||
| afterColon: true | ||
| }], |
There was a problem hiding this comment.
Suggested change
| '@typescript-eslint/key-spacing': [2, { | |
| beforeColon: false, | |
| afterColon: true | |
| }], | |
| '@typescript-eslint/key-spacing': stylisticIssues['key-spacing'], |
with stylisticIssues require'd at top of file.
|
Fixed all the things: 27a2f72 I removed the other |
jzempel
changed the title
jzempel
approved these changes
Feb 1, 2023
|
Thanks for updating the title. I also opened a bug against |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Forgot a handful of rules from the last renovate update.
Detail