Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electronic storage overhaul migration fix #79311

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

ShnitzelX2
Copy link
Contributor

Summary

Bugfixes "electronic storage overhaul migration fix"

Purpose of change

Closes #79299

When I wrote the migration code for #79097, evidently I removed some code that was still being used.

Describe the solution

Put the MOD reading code back for migration, ignore CONTAINER for migration.

Describe alternatives you've considered

Testing

Tested with the save from #79299, mods were back on guns, no additional errors.

Additional context

I really should have asked before I changed this code in the first place. It looks like it was to migrate contents for when pockets were introduced, but I don't know how much of it still really needs to be there.

I guess I'm asking for a second opinion if anybody knows better.

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 24, 2025
@ShnitzelX2 ShnitzelX2 marked this pull request as draft January 24, 2025 21:50
@ShnitzelX2 ShnitzelX2 force-pushed the estorage-migration-fix branch from 35c497c to 1ea3aa9 Compare January 25, 2025 19:51
@ShnitzelX2
Copy link
Contributor Author

My branch had issues, so I rebased and tested every pocket type with a pre-#79097 save, along with the save from #79299.

I solely re-added the mod migration code, no errors, everything where it should be.

@ShnitzelX2 ShnitzelX2 marked this pull request as ready for review January 25, 2025 19:55
@GuardianDll GuardianDll merged commit 0e5716c into CleverRaven:master Jan 26, 2025
39 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gun mods vanished into nothingness
2 participants