Add apt-get update step into the clang-tidy job

[moxian]

Summary

None

Purpose of change

Clang-tidy runners are spuriously failing https://github.com/CleverRaven/Cataclysm-DDA/actions/runs/12967965940/job/36170475239?pr=79311

Describe the solution

The error message says

E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?

So I thought I should maybe do that...

Describe alternatives you've considered

Unclear.
I'm not exactly sure what's the root of the problem because sometimes apt-get install works totally fine. E.g. https://github.com/CleverRaven/Cataclysm-DDA/actions/runs/12967965940/job/36170475187?pr=79311 which is part of the exact same matrix as the failing one in https://github.com/CleverRaven/Cataclysm-DDA/actions/runs/12967965940/job/36170475239?pr=79311
(I'm also a bit surprised that github actions don't come with apt-get update pre-run - doing so would save them a small amount of CPU cycles, but guess there're other complications with that)

Testing

Seems to be working in my fork https://github.com/moxian/Cataclysm-DDA/actions/runs/12970195966?pr=16
But, again, I'm not 100% sure this fixes the issue for good, or if i was just lucky here

Additional context

[akrieger]

the job that's passing fetched everything from an azure look aside mirror. The failures tried fetching directly from upstream sources. My bet is it's mostly bad luck with GitHub apt infra, and upstream proactively rejecting or otherwise failing apt fetches (got overloaded?)*

[moxian]

I would absolutely agree, but I find it sus that it's only fetching in clang-tidy job that fails, and not in any of the general build matrix jobs (although I only spot-checked those). The only difference (aside from the lack of apt-get update) between clang-tidy job and basic build is that the former has gettext explicitly in the apt install list, and the latter one doesn't.

[akrieger]

Matrix builds are ubuntu 20.04 and tidy is 24.04.

[akrieger]

IDK this probably doesn't break anything / regress much.