-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make zone manager width expand up to sidebar width #79347
base: master
Are you sure you want to change the base?
Conversation
…the zone manager default.
|
I took those screenshots before merging recent changes and re-testing. I'll take new ones. |
I've updated the screenshots, but I've also had a thought that I should really widen the zone name display rather than leaving a big gap at the right-hand side of the widened zone manager. So I'm marking this as draft until I get that done. Thank you for making me think harder :-) |
I've adjusted the zone manager rendering to make better use of the increased available space and updated the screenshots again. |
Looks good! |
Summary
Interface "Zone manager will expand to match a wider sidebar."
Purpose of change
My excessive custom zone setup often doen't display well in the zone manager. More width would be useful, and seeing as I play on a QHD monitor I've got plenty space to allow for a wider zone manager. But I don't want to mess things up for play on smaller screens. I assume that people will play with a sidebar that leaves plenty space to see the map, so I think it's reasonable to widen the zone manager to match the sidebar if the sidebar is wider than it. I think this also looks nicer than having a bit of sidebar show behind the zones manager. I assume that 45 was selected as the zone manager size for good reason before, and reducing it would render zone labels almost uselessly truncated, so I left that as a minimum size rather than shrinking to match smaller sidebars.
Describe the solution
When the zone manager is displayed, check the width of the sidebar. If the sidebar is wider than the zone manager's 45 pixel default then use the sidebar width instead. Adjust the column positioning such that any extra width is used by the zone name column. No change was required for the zone options (particularly custom zone filters) to use the extra space.
Describe alternatives you've considered
None.
Testing
Loaded a couple of different test games and tried several different sidebar configurations. Checked that the zone manager matches the width of wider sidebars but doesn't shrink below the previous size for narrow sidebars.
Additional context
Before:
After - wide sidebar:
After - narrow sidebar (so no change):