Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT]: Miss Sound Preference #3869

Closed
wants to merge 33 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
09b42f3
Rewrite CHANGELOG.md for v0.5.2
EliteMasterEric Oct 12, 2024
c0b15ec
[docs] Add missing changes and links to Changelog (#3655)
Hundrec Oct 23, 2024
79188b0
Make label actions more convenient (#3771)
Hundrec Nov 3, 2024
9e13ea0
fixed a plethora of dead links (#3831)
AbnormalPoof Nov 4, 2024
ba6b4ab
Miss Sound Preference
JVNpixels Nov 16, 2024
0990842
Update Save.hx
JVNpixels Nov 16, 2024
544829f
Merge pull request #2 from JVNpixels/patch-11
JVNpixels Nov 16, 2024
919d98b
Update PreferencesMenu.hx
JVNpixels Nov 16, 2024
6fa00ed
Update PlayState.hx
JVNpixels Nov 16, 2024
84b48ed
Update PreferencesMenu.hx
JVNpixels Nov 16, 2024
be08bbe
Add `status: planned` label to label actions (#3910)
Hundrec Dec 3, 2024
861e1e7
Update PreferencesMenu.hx
JVNpixels Dec 16, 2024
5173599
Bump the Stage data version to indicate that new values were added.
EliteMasterEric Oct 12, 2024
4ce83b2
Updated Save data version to indicate new values.
EliteMasterEric Oct 12, 2024
7f8937d
Only display the Stage Editor in builds that enable it, and enable it…
EliteMasterEric Oct 12, 2024
36d7de5
Enable log messages on all builds by default after we got too many co…
EliteMasterEric Oct 18, 2024
2383fdf
Remove unused custom type resolver.
EliteMasterEric Oct 18, 2024
ec9ec20
Update save data format and error handling.
EliteMasterEric Oct 18, 2024
d6db842
Fix a typo.
EliteMasterEric Oct 18, 2024
b5c5693
proj hxp version bump
ninjamuffin99 Oct 18, 2024
61a7978
changelog yoink
ninjamuffin99 Oct 22, 2024
bb24821
Remove duplicate issue detector. (#3944)
EliteMasterEric Dec 18, 2024
cb131d8
Merge branch 'develop' into main
EliteMasterEric Jan 17, 2025
bc521b7
"Fixed" the Apache 2.0 LICENSE file part (#3843)
PatoFlamejanteTV Jan 17, 2025
c3a188b
[GITHUB] Create a dedicated charting issue template (and bump version…
Hundrec Jan 17, 2025
5d5d12d
[ENHANCEMENT]: Compiling Error Issue Template (#3835)
JVNpixels Jan 17, 2025
4908adc
Update Save.hx
JVNpixels Jan 18, 2025
48a72ce
Add status: stale to auto-close (#4017)
Hundrec Jan 23, 2025
981aad2
Change size label names in PR labeler (#3918)
Hundrec Jan 23, 2025
2adae38
Update Contributing section in README (#4026)
Hundrec Jan 23, 2025
7e0f4d9
Update labeler workflow (#4023)
AbnormalPoof Jan 23, 2025
0c06ba9
Add needs r&d label to unlabel list (#4034)
Hundrec Jan 24, 2025
3d61c26
Merge branch 'FunkinCrew:main' into patch-10
JVNpixels Jan 25, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ body:
attributes:
label: Version
description: Which version are you playing on? The game version is in the bottom left corner of the main menu.
placeholder: ex. 0.5.0
placeholder: ex. 0.5.3
validations:
required: true

Expand Down
70 changes: 70 additions & 0 deletions .github/ISSUE_TEMPLATE/charting.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
name: Charting Issue
description: Report an issue with the placement of notes in the game.
labels: ["type: charting issue", "status: pending triage"]
title: "Charting Issue: "
body:
- type: checkboxes
attributes:
label: Issue Checklist
description: Be sure to complete these steps to increase the chances of your issue being addressed!
options:
- label: I have properly named my issue
- label: I have checked the Issues/Discussions pages to see if my issue has already been reported

- type: dropdown
attributes:
label: Platform
description: Which platform are you playing on?
options:
- Newgrounds (Web/HTML5)
- Itch.io (Web/HTML5)
- Itch.io (Downloadable Build) - Windows
- Itch.io (Downloadable Build) - MacOS
- Itch.io (Downloadable Build) - Linux
- Compiled from GitHub Source Code
validations:
required: true

- type: dropdown
attributes:
label: Browser
description: (Web/HTML5 users only) Which browser are you playing on?
options:
- Google Chrome
- Microsoft Edge
- Firefox
- Opera
- Safari
- Other (Specify in Description field)

- type: input
attributes:
label: Version
description: Which version are you playing on? The game version is in the bottom left corner of the main menu.
placeholder: ex. 0.5.3
validations:
required: true

- type: markdown
attributes:
value: "## Describe the charting issue(s)."

- type: markdown
attributes:
value: "### Please do not report issues from other engines. These must be reported in their respective repositories."

- type: textarea
attributes:
label: Location
description: Where did you find the issue(s)? Include the name of the song, the variation, the difficulty, the time/section of the song, and any images or videos.
placeholder: ex. Cocoa Erect on Erect/Nightmare difficulties at Section 30
validations:
required: true

- type: textarea
attributes:
label: Description
description: Why do you believe this is an issue? Is a note at the wrong time, a hold note too short/long, or something else?
placeholder: Describe the charting issue(s) here...
validations:
required: true
47 changes: 47 additions & 0 deletions .github/ISSUE_TEMPLATE/compiling.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
name: Compiling Report
description: Report an issue with compiling the game.
labels: ["type: compilation help", "status: pending triage"]
title: "Compiling Report: "
body:
- type: checkboxes
attributes:
label: Issue Checklist
description: Be sure to complete these steps to increase the chances of your issue being addressed!
options:
- label: I have properly named my issue
- label: I have checked the Issues/Discussions pages to see if my issue has already been reported

- type: dropdown
attributes:
label: Platform
description: Which platform are you compiling to/for?
options:
- Web/HTML5
- Desktop
- Other
validations:
required: true

- type: input
attributes:
label: Version
description: Which version are you compiling? The game version is in the bottom left corner of the main menu or in the project.hxp file.
placeholder: ex. 0.5.3
validations:
required: true

- type: markdown
attributes:
value: "## Describe your compiling error."

- type: markdown
attributes:
value: "### Please do not report issues from other engines. These must be reported in their respective repositories."

- type: textarea
attributes:
label: Description (include any images, videos, errors of terminal or console, error logs)
description: Provide as much detail as you can. The better others understand your issue, the more they can help you!
placeholder: Describe your issue here...
validations:
required: true
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/crash.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ body:
attributes:
label: Version
description: Which version are you playing on? The game version is in the bottom left corner of the main menu.
placeholder: ex. 0.5.0
placeholder: ex. 0.5.3
validations:
required: true

Expand Down
12 changes: 6 additions & 6 deletions .github/changed-lines-count-labeler.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
# Add 'small' to any changes below 10 lines
small:
# Add 'size: small' to any changes below 10 lines
'size: small':
max: 9

# Add 'medium' to any changes between 10 and 100 lines
medium:
# Add 'size: medium' to any changes between 10 and 100 lines
'size: medium':
min: 10
max: 99

# Add 'large' to any changes of at least 100 lines
large:
# Add 'size: large' to any changes of at least 100 lines
'size: large':
min: 100
127 changes: 120 additions & 7 deletions .github/label-actions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,38 +7,151 @@
comment: >
This issue is a duplicate. Please direct all discussion to the original issue.
# Close the issue
close: true
close: false
# Set a close reason
# close-reason: 'not planned'
# Remove other status labels
unlabel:
- 'status: accepted'
- 'status: bug reproduced'
- 'status: cannot reproduce'
- 'status: needs clarification'
- 'status: needs r&d'
- 'status: needs revision'
- 'status: pending pull request'
- 'status: pending triage'
# Set a close reason
close-reason: 'not planned'
- 'status: planned'
- 'status: rejected'
- 'status: resolved'
- 'status: resolved internally'
- 'status: reviewing internally'
- 'status: stale'
prs:
# Post a comment
comment: >
This pull request is a duplicate. Please direct all discussion to the original pull request.
# Close the pull request
close: false
# Remove other status labels
unlabel:
- 'status: accepted'
- 'status: bug reproduced'
- 'status: cannot reproduce'
- 'status: needs clarification'
- 'status: needs r&d'
- 'status: needs revision'
- 'status: pending pull request'
- 'status: pending triage'
# Close the pull request
- 'status: planned'
- 'status: rejected'
- 'status: resolved'
- 'status: resolved internally'
- 'status: reviewing internally'
- 'status: stale'

'status: stale':
issues:
# Close the issue
close: true
# Set a close reason
close-reason: 'not planned'
# Remove other status labels
unlabel:
- 'status: accepted'
- 'status: bug reproduced'
- 'status: cannot reproduce'
- 'status: duplicate'
- 'status: needs clarification'
- 'status: needs r&d'
- 'status: needs revision'
- 'status: pending pull request'
- 'status: pending triage'
- 'status: planned'
- 'status: rejected'
- 'status: resolved'
- 'status: resolved internally'
- 'status: reviewing internally'
prs:
# Close the pull request
close: true
# Remove other status labels
unlabel:
- 'status: accepted'
- 'status: bug reproduced'
- 'status: cannot reproduce'
- 'status: duplicate'
- 'status: needs clarification'
- 'status: needs r&d'
- 'status: needs revision'
- 'status: pending pull request'
- 'status: pending triage'
- 'status: planned'
- 'status: rejected'
- 'status: resolved'
- 'status: resolved internally'
- 'status: reviewing internally'

'status: rejected':
issues:
# Close the issue
close: true
# Set a close reason
close-reason: 'not planned'
# Remove other status labels
unlabel:
- 'status: accepted'
- 'status: bug reproduced'
- 'status: cannot reproduce'
- 'status: duplicate'
- 'status: needs clarification'
- 'status: needs r&d'
- 'status: needs revision'
- 'status: pending pull request'
- 'status: pending triage'
# Set a close reason
close-reason: 'not planned'
- 'status: planned'
- 'status: resolved'
- 'status: resolved internally'
- 'status: reviewing internally'
- 'status: stale'
prs:
# Close the pull request
close: true
# Remove other status labels
unlabel:
- 'status: accepted'
- 'status: bug reproduced'
- 'status: cannot reproduce'
- 'status: duplicate'
- 'status: needs clarification'
- 'status: needs r&d'
- 'status: needs revision'
- 'status: pending pull request'
- 'status: pending triage'
- 'status: planned'
- 'status: resolved'
- 'status: resolved internally'
- 'status: reviewing internally'
- 'status: stale'

'status: resolved':
issues:
# Close the issue
close: true
# Set a close reason
close-reason: 'not planned'
close-reason: 'completed'
# Remove other status labels
unlabel:
- 'status: accepted'
- 'status: bug reproduced'
- 'status: cannot reproduce'
- 'status: duplicate'
- 'status: needs clarification'
- 'status: needs r&d'
- 'status: needs revision'
- 'status: pending pull request'
- 'status: pending triage'
- 'status: planned'
- 'status: rejected'
- 'status: resolved internally'
- 'status: reviewing internally'
- 'status: stale'
11 changes: 9 additions & 2 deletions .github/labeler.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,18 @@
# Add Documentation tag to PR's changing markdown files, or anything in the docs folder
Documentation:
'pr: documentation':
- changed-files:
- any-glob-to-any-file:
- docs/*
- '**/*.md'

# Add Haxe tag to PR's changing haxe code files
Haxe:
'pr: haxe':
- changed-files:
- any-glob-to-any-file: '**/*.hx'

# Add GitHub tag to PR's changing yml files, or anything in the .github folder
'pr: github':
- changed-files:
- any-glob-to-any-file:
- github/*
- '**/*.yml'
30 changes: 0 additions & 30 deletions .github/workflows/label-issue.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,36 +7,6 @@ on:
- edited

jobs:
# When an issue is opened, perform a similarity check for potential duplicates.
# If some are found, add a label and comment listing the potential duplicate issues.
potential-duplicate:
name: Detect potential duplicate issues
runs-on: ubuntu-latest
steps:
- uses: wow-actions/potential-duplicates@v1
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# Issue title filter work with anymatch https://www.npmjs.com/package/anymatch.
# Any matched issue will stop detection immediately.
# You can specify multi filters in each line.
filter: ''
# Exclude keywords in title before detecting.
exclude: ''
# Label to set, when potential duplicates are detected.
label: 'potential duplicate'
# Get issues with state to compare. Supported state: 'all', 'closed', 'open'.
state: all
# If similarity is higher than this threshold([0,1]), issue will be marked as duplicate.
# Turn this up if the detection is too sensitive
threshold: 0.6
# Reactions to be add to comment when potential duplicates are detected.
# Available reactions: "-1", "+1", "confused", "laugh", "heart", "hooray", "rocket", "eyes"
# reactions: '-1'
# Comment to post when potential duplicates are detected.
comment: >
Potential duplicates: {{#issues}}
- [#{{ number }}] {{ title }} ({{ accuracy }}%)
{{/issues}}
# When an issue is opened, detect if it has an empty body or incomplete issue form.
# If it does, close the issue immediately.
empty-issues:
Expand Down
Loading
Loading