Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no dialogue music crash fix #4057

Closed

Conversation

Lasercar
Copy link

Does this PR close any issues? If so, link them below.

Briefly describe the issue(s) fixed.

A one line fix that prevents a null reference error crash if a dialogue doesn't have any music set when the dialogue ends.

Include any relevant screenshots or videos.

@github-actions github-actions bot added size: small A small pull request with 10 or fewer changes. pr: haxe PR modifies game code. status: pending triage Awaiting review. and removed size: small A small pull request with 10 or fewer changes. labels Jan 28, 2025
@Hundrec Hundrec added size: small A small pull request with 10 or fewer changes. type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression labels Jan 28, 2025
@EliteMasterEric EliteMasterEric added this to the 0.6.0 (Pit Stop 2) milestone Jan 28, 2025
@EliteMasterEric EliteMasterEric added status: rejected Issue did not pass review or PR cannot be approved. and removed status: pending triage Awaiting review. labels Jan 28, 2025
@EliteMasterEric
Copy link
Member

This already got done internally 👍

@AbnormalPoof AbnormalPoof removed type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression size: small A small pull request with 10 or fewer changes. pr: haxe PR modifies game code. labels Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: rejected Issue did not pass review or PR cannot be approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants