Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [fix](schema-change) Fix single column table could not rename columns #47275 #47430

Open
wants to merge 1 commit into
base: branch-3.0
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #47275

…#47275)

Single column tables was not able to rename column due to light schema
change check in error way.
@github-actions github-actions bot requested a review from dataroaring as a code owner January 24, 2025 10:20
@Thearas
Copy link
Contributor

Thearas commented Jan 24, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jan 24, 2025
@Thearas
Copy link
Contributor

Thearas commented Jan 24, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 42093 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 560706f9f242543a6c6d9f667fae53bb1e1e2d94, data reload: false

------ Round 1 ----------------------------------
q1	17791	7686	7352	7352
q2	2051	162	182	162
q3	10626	1298	1227	1227
q4	10749	766	718	718
q5	7834	3431	2968	2968
q6	251	153	150	150
q7	1014	641	614	614
q8	9717	2094	2195	2094
q9	6958	6571	6595	6571
q10	7800	2360	2350	2350
q11	483	274	272	272
q12	452	233	220	220
q13	18103	3081	3005	3005
q14	232	210	211	210
q15	569	527	521	521
q16	673	583	596	583
q17	1037	588	703	588
q18	7342	6755	6790	6755
q19	1445	1100	1102	1100
q20	484	200	199	199
q21	4355	3438	3452	3438
q22	1109	1004	996	996
Total cold run time: 111075 ms
Total hot run time: 42093 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7487	7359	7856	7359
q2	357	237	251	237
q3	3192	3022	2968	2968
q4	2171	1886	1850	1850
q5	5747	5819	5750	5750
q6	230	145	139	139
q7	2231	1848	1843	1843
q8	3359	3572	3512	3512
q9	8971	8941	8899	8899
q10	3678	3608	3579	3579
q11	604	483	504	483
q12	811	603	587	587
q13	5403	3161	3151	3151
q14	312	268	279	268
q15	568	510	526	510
q16	718	657	632	632
q17	1840	1619	1592	1592
q18	8228	7615	7397	7397
q19	1799	1672	1647	1647
q20	2054	1840	1790	1790
q21	5478	5328	5157	5157
q22	1103	1036	1011	1011
Total cold run time: 66341 ms
Total hot run time: 60361 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191413 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 560706f9f242543a6c6d9f667fae53bb1e1e2d94, data reload: false

query1	960	367	397	367
query2	6511	2192	2081	2081
query3	6698	220	219	219
query4	33804	23465	23409	23409
query5	4379	464	438	438
query6	274	182	180	180
query7	4641	320	311	311
query8	281	222	224	222
query9	9445	2683	2669	2669
query10	480	254	256	254
query11	18187	15232	15218	15218
query12	166	100	99	99
query13	1627	426	398	398
query14	8996	7761	6582	6582
query15	255	170	178	170
query16	8124	467	486	467
query17	1602	587	570	570
query18	2148	287	301	287
query19	322	154	147	147
query20	114	104	107	104
query21	213	99	99	99
query22	4597	4196	4141	4141
query23	35040	33626	34006	33626
query24	11269	2885	2873	2873
query25	647	391	392	391
query26	1559	169	170	169
query27	2977	331	349	331
query28	8057	2390	2402	2390
query29	962	452	447	447
query30	332	182	172	172
query31	1039	789	838	789
query32	95	60	67	60
query33	798	313	316	313
query34	918	514	527	514
query35	876	749	728	728
query36	1081	926	954	926
query37	141	82	76	76
query38	4028	3858	3868	3858
query39	1497	1419	1435	1419
query40	281	106	105	105
query41	56	52	51	51
query42	122	108	103	103
query43	568	500	507	500
query44	1331	804	797	797
query45	189	166	166	166
query46	1138	715	708	708
query47	1939	1832	1845	1832
query48	471	381	364	364
query49	1223	388	398	388
query50	817	421	430	421
query51	7306	7052	6963	6963
query52	109	93	92	92
query53	262	188	194	188
query54	1220	470	460	460
query55	82	83	74	74
query56	277	259	253	253
query57	1247	1121	1115	1115
query58	232	215	214	214
query59	3140	2995	3139	2995
query60	275	263	258	258
query61	115	138	114	114
query62	850	681	686	681
query63	224	201	198	198
query64	5419	664	641	641
query65	3266	3220	3192	3192
query66	1312	317	319	317
query67	16168	15735	15745	15735
query68	3664	589	585	585
query69	402	265	273	265
query70	1208	1041	1143	1041
query71	317	256	263	256
query72	6201	4065	4180	4065
query73	756	350	354	350
query74	9853	9040	9288	9040
query75	3441	2646	2658	2646
query76	2758	1153	1165	1153
query77	428	307	286	286
query78	10494	9703	9572	9572
query79	1091	597	608	597
query80	785	458	443	443
query81	510	246	246	246
query82	1252	126	127	126
query83	265	156	159	156
query84	242	89	87	87
query85	1081	361	356	356
query86	314	306	294	294
query87	4449	4348	4281	4281
query88	3536	2418	2382	2382
query89	416	300	303	300
query90	1987	195	196	195
query91	198	164	162	162
query92	64	55	61	55
query93	1063	561	546	546
query94	742	317	315	315
query95	406	264	255	255
query96	614	291	278	278
query97	3327	3155	3163	3155
query98	216	198	199	198
query99	1527	1362	1288	1288
Total cold run time: 298386 ms
Total hot run time: 191413 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.64 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 560706f9f242543a6c6d9f667fae53bb1e1e2d94, data reload: false

query1	0.03	0.03	0.02
query2	0.06	0.04	0.03
query3	0.23	0.06	0.07
query4	1.64	0.10	0.10
query5	0.53	0.53	0.51
query6	1.14	0.73	0.72
query7	0.02	0.02	0.02
query8	0.03	0.04	0.03
query9	0.58	0.50	0.51
query10	0.57	0.56	0.57
query11	0.15	0.09	0.12
query12	0.15	0.11	0.12
query13	0.61	0.59	0.60
query14	2.85	2.73	2.77
query15	0.90	0.83	0.83
query16	0.38	0.36	0.40
query17	1.03	1.06	1.05
query18	0.24	0.22	0.22
query19	1.92	1.74	2.06
query20	0.01	0.02	0.01
query21	15.35	0.59	0.56
query22	3.07	2.94	1.76
query23	17.05	0.89	0.85
query24	3.47	0.81	1.76
query25	0.36	0.12	0.17
query26	0.45	0.13	0.13
query27	0.04	0.05	0.04
query28	9.84	1.11	1.08
query29	12.54	3.27	3.31
query30	0.25	0.06	0.06
query31	2.85	0.40	0.39
query32	3.26	0.46	0.46
query33	2.98	3.00	3.05
query34	16.94	4.53	4.49
query35	4.66	4.57	4.55
query36	0.67	0.51	0.49
query37	0.10	0.06	0.06
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.16	0.12	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.35 s
Total hot run time: 32.64 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants