-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_test_utils): porting autoware_test_utils from universe to core #172
base: main
Are you sure you want to change the base?
feat(autoware_test_utils): porting autoware_test_utils from universe to core #172
Conversation
Signed-off-by: JianKangEgon <[email protected]>
Signed-off-by: JianKangEgon <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
This pr depends on the new ported package "autoware_utils": autowarefoundation/autoware_utils#23 and "autoware_internal_msgs": autowarefoundation/autoware_internal_msgs#45 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jncr gen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this package is only used during testing, as its name suggests, it shouldn’t be in the common
directory. I think it would be better to create a tests
directory and move it there just like the demos
directory.
<depend>autoware_map_msgs</depend> | ||
<depend>autoware_perception_msgs</depend> | ||
<depend>autoware_planning_msgs</depend> | ||
<depend>autoware_pyplot</depend> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't migrate this package yet and I think we don't need to do it because it's for the visualization. cc @mitsudome-r
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Kondo san @youtalk
Thanks for reviewing this pr
Already revised the package according to your comment,
Best regards
心刚
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the usages too.
Signed-off-by: NorahXiong <[email protected]>
Signed-off-by: NorahXiong <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
===========================================
- Coverage 78.75% 46.10% -32.66%
===========================================
Files 11 17 +6
Lines 193 950 +757
Branches 73 529 +456
===========================================
+ Hits 152 438 +286
- Misses 11 306 +295
- Partials 30 206 +176
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this package is only used during testing, as its name suggests, it shouldn’t be in the
common
directory. I think it would be better to create atests
directory and move it there just like thedemos
directory.
@JianKangEgon Please move directory according to my comment.
autoware_lanelet2_extension: | ||
type: git | ||
url: https://github.com/autowarefoundation/autoware_lanelet2_extension | ||
version: main | ||
autoware_msgs: | ||
type: git | ||
url: https://github.com/autowarefoundation/autoware_msgs | ||
version: main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are duplicated.
autoware_lanelet2_extension: | |
type: git | |
url: https://github.com/autowarefoundation/autoware_lanelet2_extension | |
version: main | |
autoware_msgs: | |
type: git | |
url: https://github.com/autowarefoundation/autoware_msgs | |
version: main |
#include <autoware/pyplot/patches.hpp> | ||
#include <autoware/pyplot/pyplot.hpp> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to remove them and the usages too.
Description
We are porting autoware_test_utils to autoware.core, and this PR adds the package to core.
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.