feat(autoware_trajectory): update autoware_trajectory interfaces #10034
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
Change in average Code Health of affected files: -0.27 (9.91 -> 9.64)
- Declining Code Health: 12 findings(s) 🚩
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method example_shift.cpp: main
- Complex Method shift.cpp: shift_impl
- Large Method example_trajectory_point.cpp: main
- Complex Conditional crossed.cpp: crossed_with_constraint_impl
- Complex Conditional shift.cpp: calc_base_lengths
- Complex Method shift.cpp: calc_base_lengths
- Complex Method crossed.cpp: crossed_with_constraint_impl
- Excess Number of Function Arguments crossed.cpp: crossed_with_constraint_impl
- Complex Conditional find_intervals.cpp: find_intervals_impl
- Excess Number of Function Arguments shift.cpp: get_base_lengths_without_accel_limit
- Bumpy Road Ahead crossed.cpp: crossed_with_constraint_impl
- Bumpy Road Ahead shift.cpp: shift_impl
Annotations
Check warning on line 187 in common/autoware_trajectory/examples/example_shift.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
main has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 119 in common/autoware_trajectory/examples/example_trajectory_point.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Large Method
main increases from 81 to 84 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Check warning on line 59 in common/autoware_trajectory/src/utils/crossed.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
crossed_with_constraint_impl has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 50 in common/autoware_trajectory/src/utils/crossed.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Conditional
crossed_with_constraint_impl has 1 complex conditionals with 3 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
Check warning on line 59 in common/autoware_trajectory/src/utils/crossed.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
crossed_with_constraint_impl has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check warning on line 59 in common/autoware_trajectory/src/utils/crossed.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Excess Number of Function Arguments
crossed_with_constraint_impl has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Check warning on line 33 in common/autoware_trajectory/src/utils/find_intervals.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Conditional
find_intervals_impl has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
Check warning on line 278 in common/autoware_trajectory/src/utils/shift.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
shift_impl has a cyclomatic complexity of 13, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 225 in common/autoware_trajectory/src/utils/shift.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
calc_base_lengths has a cyclomatic complexity of 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 136 in common/autoware_trajectory/src/utils/shift.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Conditional
calc_base_lengths has 1 complex conditionals with 3 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
Check warning on line 278 in common/autoware_trajectory/src/utils/shift.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
shift_impl has 3 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check warning on line 80 in common/autoware_trajectory/src/utils/shift.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Excess Number of Function Arguments
get_base_lengths_without_accel_limit has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.