-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_trajectory): update autoware_trajectory interfaces #10034
feat(autoware_trajectory): update autoware_trajectory interfaces #10034
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Y.Hisaki <[email protected]>
f8a7525
to
9cd2ce9
Compare
detail::to_point(shifted_points.back()).y -= std::cos(azimuth) * shift_length; | ||
} | ||
auto shifted_trajectory = reference_trajectory; | ||
bool valid = shifted_trajectory.build(shifted_points); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add const
Signed-off-by: Y.Hisaki <[email protected]>
Signed-off-by: Y.Hisaki <[email protected]>
Signed-off-by: Y.Hisaki <[email protected]>
Signed-off-by: Y.Hisaki <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10034 +/- ##
==========================================
- Coverage 29.78% 29.75% -0.03%
==========================================
Files 1436 1451 +15
Lines 108308 108544 +236
Branches 42956 43016 +60
==========================================
+ Hits 32256 32301 +45
- Misses 72920 73105 +185
- Partials 3132 3138 +6
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
This PR contains many changes, but the major changes are described in the following list.
Move key functions from member to external.
before
double s = trajectory.closest(p);
after
double s = utils::closest(trajectory, p);
Add shift function
Add find_intervals function
And some style changes...
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.